[minor_change] Add pagination support for aci_rest module (DCNE-101)

[edudppaz]

This change adds "page_size" and "page" optional paremeters to the aci_rest module in order to support pagination.

if the page_size parameter is set on a GET request, it controls the amount of objects to be returned on each page by the APIC response, then the page parameter controls which page is returned to the module.
If the page parameter is not set, it returns the first page by default (0)

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 35.72%. Comparing base (7272ad6) to head (e8bf63a).

Files with missing lines	Patch %	Lines
plugins/modules/aci_rest.py	0.00%	7 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (7272ad6) and HEAD (e8bf63a). Click for more details.

HEAD has 14 uploads less than BASE

Flag	BASE (7272ad6)	HEAD (e8bf63a)
integration	2	0
unit	8	0
sanity	8	4

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #711       +/-   ##
===========================================
- Coverage   95.67%   35.72%   -59.95%     
===========================================
  Files         270      267        -3     
  Lines       12405    12225      -180     
  Branches     1874     1849       -25     
===========================================
- Hits        11868     4367     -7501     
- Misses        406     7858     +7452     
+ Partials      131        0      -131     

Flag	Coverage Δ
integration	?
sanity	35.72% <0.00%> (-0.03%)	⬇️
unit	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[akinross]

There seems to be a issue when doing setting url and path in this way when path contains other filters. As an example if path is "/api/class/fvSubnet.json?order-by=fvSubnet.descr" and you would add page information as above it would display the url as "https://173.36.219.82/api/class/fvSubnet.json?order-by=fvSubnet.descr?page=0&page-size=3" but would sent correctly to https://173.36.219.82:443/api/class/fvSubnet.json?order-by=fvSubnet.descr&page=0&page-size=3

as temp workaround tested that leveraging the update_qsl() function will display it correctly

Suggested change

	aci.path = "{0}?page={1}&page-size={2}".format(aci.path, page, page_size)
	aci.url = update_qsl(aci.url, {"page": page, "page-size": page_size})
	aci.path = update_qsl(aci.path, {"page": page, "page-size": page_size})
	aci.url = update_qsl(aci.url, {"page": page, "page-size": page_size})

I do think however we should rootcause this, because it is likely that similar behaviour is present for rsp-subtree

[edudppaz]

I´ll look into this. thanks.

[akinross]

LGTM

[shrsr]

LGTM

[gmicol]

LGTM

[samiib]

LGTM

[akinross]

LGTM

[sajagana]

LGTM!

[samiib]

LGTM

[shrsr]

LGTM

[gmicol]

LGTM

[lhercot]

LGTM

[lhercot]

Thank you for your contribution!