Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove authentication default for public endpoints #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove authentication default for public endpoints #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions pybitx/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,37 +80,37 @@ def api_request(self, call, params, kind='auth', http_call='get'):
else:
return result

def get_ticker(self, kind='auth'):
def get_ticker(self, kind='basic'):
params = {'pair': self.pair}
return self.api_request('ticker', params, kind=kind)

def get_all_tickers(self, kind='auth'):
def get_all_tickers(self, kind='basic'):
return self.api_request('tickers', None, kind=kind)

def get_order_book(self, limit=None, kind='auth'):
def get_order_book(self, limit=None, kind='basic'):
params = {'pair': self.pair}
orders = self.api_request('orderbook', params, kind=kind)
if limit is not None:
orders['bids'] = orders['bids'][:limit]
orders['asks'] = orders['asks'][:limit]
return orders

def get_order_book_frame(self, limit=None, kind='auth'):
def get_order_book_frame(self, limit=None, kind='basic'):
q = self.get_order_book(limit, kind)
asks = pd.DataFrame(q['asks'])
bids = pd.DataFrame(q['bids'])
index = pd.MultiIndex.from_product([('asks', 'bids'),('price', 'volume')])
df = pd.DataFrame(pd.concat([asks, bids], axis=1).values, columns=index)
return df

def get_trades(self, limit=None, kind='auth'):
def get_trades(self, limit=None, kind='basic'):
params = {'pair': self.pair}
trades = self.api_request('trades', params, kind=kind)
if limit is not None:
trades['trades'] = trades['trades'][:limit]
return trades

def get_trades_frame(self, limit=None, kind='auth'):
def get_trades_frame(self, limit=None, kind='basic'):
trades = self.get_trades(limit, kind)
df = pd.DataFrame(trades['trades'])
df.index = pd.to_datetime(df.timestamp * 1e-3, unit='s')
Expand Down