-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing env #259
Fix missing env #259
Conversation
Not sure if we should also update the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yeelauren! Thanks for opening this, the conda environment definitely needs an update with all the recent changes. Could you refresh the conda-lock.yml
file as @yellowcap mentioned after adding stacchip
(see suggestion below)? You can do this by following the instructions at https://clay-foundation.github.io/model/installation.html#advanced, i.e. run:
conda-lock lock --mamba --file environment.yml --with-cuda=12.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also noticed that this repo is missing a reference to the submodule stacchip
Yes, could you add the following lines (copied from #211) to the environment.yml file:
- pip
- pip:
- https://github.com/Clay-foundation/stacchip/archive/refs/tags/0.1.30.zip
@yellowcap, just confirming that it's v0.1.30 that we want here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stacchip is pip installable now 😄 https://pypi.org/project/stacchip/ So the addition should read
- pip
- pip:
- stacchip==0.1.30
We removed the stacchip library from the dependencies, as it was only used in one notebook for one tiny function. The updated wall-to-wall notebook is now independent of stacchip. I think with this also the geoarrow and boto3 dependencues are no longer necessary. @yeelauren when you have time, please test your workflow again using main or the branch and let us know if the dependency issues were resolved. Btw, we are also updating other libraries on the env file in #264 |
I think this has been fixed in updating the env here #264 and removing stacchip from the wall-to-wall example here #263. @yeelauren feel free to reopen if you still encounter these problems. |
Hey friends!
While testing locally, I noticed that the
environment.yml
file seems to be missing some packages for the notebooks in/docs
.I've made my attempt at fixing the version numbers.
I also noticed that this repo is missing a reference to the submodule stacchip
model/docs/clay-v1-wall-to-wall.ipynb
Line 56 in a61f9fa
To get this to run locally, I had to copy and move the directory around for stacchip.