feat(logs): support resource logs #129
Open
+107
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miton18
force-pushed
the
feat/resource-logs-stream
branch
from
2879675 to
acf3df6
Compare
pdesoyres-cc
requested changes
Feb 21, 2025
esm/streams/resource-logs.js
Outdated
| * @returns {URL} | ||
| */ | ||
| getUrl() { | ||
| return this.buildUrl(`/v4/logs/organisations/${this._ownerId}/resources/${this._addonId}/logs`, { ...this._options, |
There was a problem hiding this comment.
nitpick: can you move the ...this._options to the next line?
esm/streams/resource-logs.js
Outdated
| // in case of pause() then resume(): | ||
| // we don' t want N another logs, we want the initial passed number less the events count already received | ||
| limit: this._computedLimit(), | ||
| service: 'all' // TODO: debug |
There was a problem hiding this comment.
question: this TODO is still valid? what do we have to debug?
esm/streams/application-logs.js
Outdated
| @@ -88,7 +88,7 @@ export class ApplicationLogStream extends CleverCloudSse { | |||
| /** | |||
| * shortcut for .on('APPLICATION_LOG', (event) => ...) | |||
| * @param {Function} fn which handle logs | |||
| * @returns {any} | |||
| * @returns {ApplicationLogStream} | |||
There was a problem hiding this comment.
nitpick: you can do @returns {this} instead.
fix: can you move that into a separate commit?
esm/streams/access-logs.js
Outdated
| @@ -89,7 +89,7 @@ export class ApplicationAccessLogStream extends CleverCloudSse { | |||
| /** | |||
| * shortcut for .on('APPLICATION_LOG', (event) => ...) | |||
| * @param {Function} fn which handle logs | |||
| * @returns {any} | |||
| * @returns {ApplicationAccessLogStream} | |||
There was a problem hiding this comment.
nitpick: you can do @returns {this} instead.
fix: can you move that into a separate commit?
miton18
force-pushed
the
feat/resource-logs-stream
branch
from
acf3df6 to
3d7fe0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.