Add new AtmosSimulation constructor
#3999
Open
+1,612
−487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adds a new
AtmosSimulationconstructor, closes #3894.The current
AtmosConfig/parsed_argssystem is monolithic and hard to use programmatically. This PR introduces a more composable constructor that makes it easier to create simulations and reduces coupling between configuration parsing and simulation setup. The core changes are insrc/simulation/AtmosSimulations.jlContent
Core Changes
AtmosSimulation{FT}constructor: Added a keyword-based constructor that doesn't requireAtmosConfig/parsed_args, allowing programmatic simulation creation with explicit parametersdefault_model_callbacks: Creates callbacks from model componentscommon_callbacks: Standard simulation callbacks (progress logging, NaN checking, checkpointing, etc.)get_callbacks.jlsetup_diagnostics_and_writersfunction to handle diagnostics initialization for both old and new constructorstypes.jlto match YAML config defaults:Utilities
convert_time_args,handle_restart,extract_diagnostic_periods,validate_checkpoint_diagnostics_consistency,parse_checkpoint_frequencyparsed_argsandsim_infofrom functions to enable reuse:args_integrator,get_jacobian,ode_configuration,get_state_restart,get_diagnostics,get_callbacks,build_cachetest/restart_AtmosSimulation.jlMiscellaneous
_DEFAULT_ATMOS_MODEL_KWARGSconstant - defaults now handled by struct definitionscore_default_diagnosticsto requiretopographyparameter explicitlyTODOs
Future Work
get_callbacksandcommon_callbackshave some redundancydtnetcdf_interpolation_num_pointsandnetcdf_output_at_levelsto new constructorget_simulationretains all desired loggingget_simulationget_simulationbut not with newAtmosSimulationconstructor