review feedback

ClickHouse · Feb 13, 2025 · 5f21955 · 5f21955
1 parent 4547713
commit 5f21955
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 9 deletions.
diff --git a/src/components/Select/MultiSelect.tsx b/src/components/Select/MultiSelect.tsx
@@ -1,4 +1,4 @@
-import { KeyboardEvent, useCallback, useState } from "react";
+import { KeyboardEvent, MouseEvent, useCallback, useState } from "react";
 
 import { useUpdateEffect } from "@/hooks";
 
@@ -14,7 +14,7 @@ export interface MultiSelectProps
   onSelect?: (
     value: Array<string>,
     type?: SelectionType,
-    evt?: KeyboardEvent<HTMLElement>
+    evt?: KeyboardEvent<HTMLElement> | MouseEvent<HTMLElement>
   ) => void;
   value?: Array<string>;
   defaultOpen?: boolean;

diff --git a/src/components/Select/SingleSelect.tsx b/src/components/Select/SingleSelect.tsx
@@ -1,4 +1,4 @@
-import { KeyboardEvent, useCallback, useState } from "react";
+import { KeyboardEvent, MouseEvent, useCallback, useState } from "react";
 
 import { useUpdateEffect } from "@/hooks";
 
@@ -14,7 +14,7 @@ export interface SelectProps
   onSelect?: (
     value: string,
     type?: SelectionType,
-    evt?: KeyboardEvent<HTMLElement>
+    evt?: KeyboardEvent<HTMLElement> | MouseEvent<HTMLElement>
   ) => void;
   value?: string;
   placeholder?: string;
@@ -52,7 +52,11 @@ export const Select = ({
   );
 
   const onSelect = useCallback(
-    (value: string, type?: SelectionType, evt?: KeyboardEvent<HTMLElement>) => {
+    (
+      value: string,
+      type?: SelectionType,
+      evt?: KeyboardEvent<HTMLElement> | MouseEvent<HTMLElement>
+    ) => {
       setSelectedValues(values => {
         if (values[0] !== value) {
           return [value];

diff --git a/src/components/Select/common/InternalSelect.tsx b/src/components/Select/common/InternalSelect.tsx
@@ -250,7 +250,7 @@ export const InternalSelect = ({
       if (e.key === "Enter") {
         e.preventDefault();
         if (highlighted) {
-          onSelect(highlighted, "default", e);
+          onSelect(highlighted, undefined, e);
         } else if (visibleList.current.length === 0 && allowCreateOption) {
           onSelect(search, "custom", e);
         }
@@ -306,7 +306,7 @@ export const InternalSelect = ({
     e.preventDefault();
     e.stopPropagation();
     if (allowCreateOption) {
-      onSelect(search, "custom");
+      onSelect(search, "custom", e);
     }
   };
 

diff --git a/src/components/Select/common/types.ts b/src/components/Select/common/types.ts
@@ -1,4 +1,4 @@
-import { HTMLAttributes, KeyboardEvent, ReactNode } from "react";
+import { HTMLAttributes, KeyboardEvent, MouseEvent, ReactNode } from "react";
 import { HorizontalDirection, IconName } from "@/components";
 import { PopoverProps } from "@radix-ui/react-popover";
 
@@ -77,7 +77,7 @@ interface InternalSelectProps
   onSelect: (
     value: string,
     type?: SelectionType,
-    evt?: KeyboardEvent<HTMLElement>
+    evt?: KeyboardEvent<HTMLElement> | MouseEvent<HTMLElement>
   ) => void;
   multiple?: boolean;
   checkbox?: boolean;