-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand cell height if there is only one row #537
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vineethasok I followed your suggestion and removed I was hoping to set a matching height on the index column using CSS, but unfortunately the cells are in |
Updated the initial description with the new implementation per the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a few nits and comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's light this candle and see what happens. I want you to keep an eye on this in Slack and escalations for the next few months: listen for reports of weird issues with grids and tables or bad performance. (Not saying this PR will cause those, but since this is a library that affects multiple areas of the application, we have a responsibility to make sure our changes don't cause regressions).
Helps with https://github.com/ClickHouse/control-plane/issues/12806
Why
Currently if there is one row of data displayed, and it's something like a

SHOW CREATE TABLE
query, it is cut off by default:What
This adds and exposes a
rowAutoHeight
prop to the Grid component. It should be set for the case when there is only one row. When set, it allows the cell height to expand to accommodate the content:Screen.Recording.2025-02-07.at.8.36.34.AM.mov
Reproduce
npm run build
sql-console/web/package.json
to"@clickhouse/click-ui": "../../../click-ui",
rm -rf node_modules && yarn cache clean && yarn && yarn build:packages
Create the following table and show the create query: