Better estimation for ColumnLowCardinality::Reserve and ColumnString::Reserve #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…:Reserve ColumnLowCardinality assumes that not all items are unique, hence dictionary column can be reserved for smaller capacity; ColumnString now allows to set average value size estimation in constructor or on existing instance. If estimation is close to real average value size, then memory is pre-allocations are close to optimum.
|
Closing to re-open and to re-trigger CI/CD |
…tests - Added validation for ColumnString::EstimatedValueSize value in ColumnString - Minor refactoring of block allocation in ColumnString - Moved test code for ColumnString and ColumnLowCardinality to separate files, - Added more test cases
Andded PrettyPrintByteSize + some tests
also removed commented out code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ColumnLowCardinality assumes that not all items are unique, hence dictionary column can be reserved for smaller capacity.
ColumnString now allows to set average value size estimation in constructor or on existing instance.
If estimation is close to real average value size, then memory pre-allocations are close to optimum.
Added method
MemoryUsagethat provides insight on the amount of RAM used by column instance.