Skip to content

[fix]: this cardinality may generate overflow problem when size>int.max #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
learn2Pro wants to merge 1 commit into from
Closed

[fix]: this cardinality may generate overflow problem when size>int.max #1140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions clickhouse-client/src/main/java/com/clickhouse/client/data/ClickHouseBitmap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.clickhouse.client.data;

import com.clickhouse.client.ClickHouseDataType;
import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream;
import java.io.DataInputStream;
Expand All @@ -16,7 +17,6 @@
import org.roaringbitmap.buffer.MutableRoaringBitmap;
import org.roaringbitmap.longlong.Roaring64Bitmap;
import org.roaringbitmap.longlong.Roaring64NavigableMap;
import com.clickhouse.client.ClickHouseDataType;

public abstract class ClickHouseBitmap {
private static final int[] EMPTY_INT_ARRAY = new int[0];
Expand Down Expand Up @@ -562,9 +562,9 @@ public long[] toLongArray() {
public ByteBuffer toByteBuffer() {
ByteBuffer buf;

int cardinality = getCardinality();
long cardinality = getLongCardinality();
if (cardinality <= 32) {
buf = newBuffer(2 + byteLen * cardinality);
buf = newBuffer(2 + byteLen * (int) cardinality);
buf.put((byte) 0);
buf.put((byte) cardinality);
if (byteLen == 1) {
Expand Down