Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust testing password #495

Merged
merged 6 commits into from
Feb 4, 2025
Merged

Adjust testing password #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
32da732
Add a configured password
Paultagoras Feb 4, 2025
4d987fb
Setting password differently
Paultagoras Feb 4, 2025
0e1c47b
Adding a new environment variable
Paultagoras Feb 4, 2025
7532f2d
Update ClickHouseTestHelpers.java
Paultagoras Feb 4, 2025
fbcd881
Update ClickHouseSinkTaskStringTest.java
Paultagoras Feb 4, 2025
d29102c
Update ClickHouseSinkTaskStringTest.java
Paultagoras Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/test/java/com/clickhouse/kafka/connect/sink/ClickHouseBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public static void setup() throws IOException {
initialPing();
return;
}
db = new ClickHouseContainer(ClickHouseTestHelpers.CLICKHOUSE_DOCKER_IMAGE);
db = new ClickHouseContainer(ClickHouseTestHelpers.CLICKHOUSE_DOCKER_IMAGE).withPassword("test_password").withEnv("CLICKHOUSE_DEFAULT_ACCESS_MANAGEMENT", "1");
db.start();
}

Expand Down
6 changes: 5 additions & 1 deletion src/test/java/com/clickhouse/kafka/connect/sink/ClickHouseSinkTaskSchemalessProxyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,11 @@ public class ClickHouseSinkTaskSchemalessProxyTest extends ClickHouseBase {
public static void setup() throws IOException {
Network network = Network.newNetwork();
// Note: we are using a different version of ClickHouse for the proxy - https://github.com/ClickHouse/ClickHouse/issues/58828
db = new ClickHouseContainer(ClickHouseTestHelpers.CLICKHOUSE_FOR_PROXY_DOCKER_IMAGE).withNetwork(network).withNetworkAliases("clickhouse");
db = new ClickHouseContainer(ClickHouseTestHelpers.CLICKHOUSE_FOR_PROXY_DOCKER_IMAGE)
.withNetwork(network)
.withNetworkAliases("clickhouse")
.withPassword("test_password")
.withEnv("CLICKHOUSE_DEFAULT_ACCESS_MANAGEMENT", "1");
db.start();

toxiproxy = new ToxiproxyContainer("ghcr.io/shopify/toxiproxy:2.7.0").withNetwork(network).withNetworkAliases("toxiproxy");
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/com/clickhouse/kafka/connect/sink/ClickHouseSinkTaskStringTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

public class ClickHouseSinkTaskStringTest extends ClickHouseBase {
private int countRowsWithEmojis(ClickHouseHelperClient chc, String topic) {
String queryCount = "select count(*) from " + topic + " where str LIKE '%\uD83D\uDE00%'";
String queryCount = "select count(*) from " + topic + " where str LIKE '%\uD83D\uDE00%' SETTINGS select_sequential_consistency = 1";
try {
Records records = chc.getClient().queryRecords(queryCount).get();
String value = records.iterator().next().getString(1);
Expand All @@ -35,7 +35,7 @@ private int countRowsWithEmojis(ClickHouseHelperClient chc, String topic) {
}
}
private int countRows(ClickHouseHelperClient chc, String topic) {
String queryCount = String.format("select count(*) from `%s`", topic);
String queryCount = String.format("select count(*) from `%s` SETTINGS select_sequential_consistency = 1", topic);
try {
Records records = chc.getClient().queryRecords(queryCount).get();
String value = records.iterator().next().getString(1);
Expand Down
6 changes: 5 additions & 1 deletion src/test/java/com/clickhouse/kafka/connect/sink/ClickHouseSinkTaskWithSchemaProxyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,11 @@ public class ClickHouseSinkTaskWithSchemaProxyTest extends ClickHouseBase {
public static void setup() throws IOException {
Network network = Network.newNetwork();
// Note: we are using a different version of ClickHouse for the proxy - https://github.com/ClickHouse/ClickHouse/issues/58828
db = new org.testcontainers.clickhouse.ClickHouseContainer(ClickHouseTestHelpers.CLICKHOUSE_FOR_PROXY_DOCKER_IMAGE).withNetwork(network).withNetworkAliases("clickhouse");
db = new org.testcontainers.clickhouse.ClickHouseContainer(ClickHouseTestHelpers.CLICKHOUSE_FOR_PROXY_DOCKER_IMAGE)
.withNetwork(network)
.withNetworkAliases("clickhouse")
.withPassword("test_password")
.withEnv("CLICKHOUSE_DEFAULT_ACCESS_MANAGEMENT", "1");
db.start();

toxiproxy = new ToxiproxyContainer("ghcr.io/shopify/toxiproxy:2.7.0").withNetwork(network).withNetworkAliases("toxiproxy");
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/com/clickhouse/kafka/connect/sink/helper/ClickHouseTestHelpers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ public static OperationMetrics optimizeTable(ClickHouseHelperClient chc, String
}

public static int countRows(ClickHouseHelperClient chc, String tableName) {
String queryCount = String.format("SELECT COUNT(*) FROM `%s`", tableName);
String queryCount = String.format("SELECT COUNT(*) FROM `%s` SETTINGS select_sequential_consistency = 1", tableName);

try {
optimizeTable(chc, tableName);
Expand Down Expand Up @@ -212,7 +212,7 @@ public static int sumRows(ClickHouseHelperClient chc, String tableName, String c
}

public static int countRowsWithEmojis(ClickHouseHelperClient chc, String tableName) {
String queryCount = "SELECT COUNT(*) FROM `" + tableName + "` WHERE str LIKE '%\uD83D\uDE00%'";
String queryCount = "SELECT COUNT(*) FROM `" + tableName + "` WHERE str LIKE '%\uD83D\uDE00%' SETTINGS select_sequential_consistency = 1";
try {
Records records = chc.getClient().queryRecords(queryCount).get(CLOUD_TIMEOUT_VALUE, CLOUD_TIMEOUT_UNIT);
String value = records.iterator().next().getString(1);
Expand Down