Don't specify 'readonly' twice if it appears in the client's option list #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Olivia Trewin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
serprex
reviewed
Nov 16, 2024
| .await | ||
| .unwrap(); | ||
|
|
||
| assert_eq!(got_string, long_string); |
There was a problem hiding this comment.
ideally assert would be that readonly came through as 2. Changing query to show readonly could have that effect
serprex
approved these changes
Nov 16, 2024
loyd
reviewed
Nov 19, 2024
| @@ -147,7 +147,7 @@ impl Query { | |||
| let use_post = !read_only || query.len() > MAX_QUERY_LEN_TO_USE_GET; | |||
|
|
|||
| let (method, body, content_length) = if use_post { | |||
| if read_only { | |||
| if read_only && !self.client.options.contains_key("readonly") { | |||
There was a problem hiding this comment.
What if read-only=0 is provided? According to https://clickhouse.com/docs/en/operations/settings/permissions-for-queries#readonly, we must use POST for such queries, so it should also affect the use_post flag.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If a user specifies the "readonly" option at the client level and tries to execute a query too long to fit in the GET request's query parameters, "readonly" is set twice in the header - once as "1" and again as whatever the user specified. In particular, this means it's not possible to set another value for "readonly" on queries that use the POST method. Bypass setting "readonly" the first time if it's part of the Client's options already.
Checklist
Delete items not relevant to your PR: