Onboarding Flows - Theme: Yoda #946

ghost · 2017-02-28T12:14:35Z

Signed-off-by: Denisa Dan [email protected]

levice14 · 2017-03-01T07:11:55Z

👍

please sign commit messages in the future - please edit PR message to add sign-off line there too (these are part of our contritbution guidelines) - you can see an example here
you should add in the future more descriptive commit message - "initial commit"?
the build fails with metadata extraction failure - I adivice to run the builder tool locally to compile the project before pushing

12:13:59 [ERROR] 
12:13:59 [ERROR] ------------------------------------------------------------
12:13:59 [ERROR] Exception: Failed to extract metadata for file: '/home/ubuntu/cloud-slang-content/content/io/cloudslang/samples/yoda/quote_check.sl'.
null
12:13:59 [ERROR] Exception: Some Slang files were not pre-compiled.
Found: 580 executable files in path: '/home/ubuntu/cloud-slang-content/content' But managed to create slang models for only: 579
12:13:59 [ERROR] FAILURE: Validation of slang files for project: "/home/ubuntu/cloud-slang-content" failed.
12:13:59 [ERROR] ------------------------------------------------------------
12:13:59 [ERROR]

levice14 · 2017-03-01T08:19:12Z

please also shortly describe in the PR message what the use case is

tethryus · 2017-03-01T08:57:44Z

Hello @dandenisa and congrats on your first PR on cloud-slang-content.

tethryus

Please move the .sl files in the correct folder. ATM they are in io.cloudslang.samples

They should be in io.cloudslang.content.

And is the folder going to be samples, or some of it can be added to other folders?

tethryus

Had a couple of comments, other than that, great job.

tethryus · 2017-03-01T09:02:49Z

content/io/cloudslang/samples/yoda/quote_check.sl

+# The Apache License is available at
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+#########################################################################################################################!!


This might be the error in CircleCi and Travis, the "!!" at the end of ".....#########" and the fact that you don`t have the YAML start text tag : "#!!" after them

tethryus · 2017-03-01T09:03:21Z

content/io/cloudslang/samples/yoda/print_image.sl

+          base.print_text:
+            - text: ${read_text}
+        navigate:
+          - SUCCESS: SUCCESS


Please add the final result of the operation: SUCCESS and FAILURE

tethryus · 2017-03-01T09:04:32Z

resources/samples/yoda/yoda_ascii_image.txt

@@ -0,0 +1,225 @@
+


@Bonczidai Do we allow text files in the content as "resource" files? Or can it be added manually whenever you want to run any operation or flow related to Yoda.

tethryus · 2017-03-01T09:05:01Z

resources/samples/yoda/yoda_quotes.txt

@@ -0,0 +1 @@
+May the Force be with you;You will find only what you bring in;Size matters not;Do or do not. There is no try;The fear of loss is a path to the Dark Side;Truly wonderful the mind of a child is;Always two there are, no more, no less. A master and an apprentice;You must unlearn what you have learned;In a dark place we find ourselves, and a little more knowledge lights our way;Train yourself to let go of everything you fear to lose;Fear is the path to the dark side. Fear leads to anger, anger leads to hate, hate leads to suffering;Always pass on what you have learned;To be Jedi is to face the truth, and choose. Give off light, or darkness, Padawan. Be a candle, or the night;


The same applies here (see above).

tethryus · 2017-03-01T09:05:50Z

content/io/cloudslang/samples/yoda/quote_check.sl

+    inputs:
+      - default_quote:
+          default: "Do or do not, there is no try!"
+          private: true


Setting this as private true, means that you cannot change it`s value. Is it the desired effect, or do we want the user to be able to use other quotes as well?

tethryus · 2017-03-01T09:06:42Z

content/io/cloudslang/samples/yoda/quote_check.sl

+
+      - print_random_quote:
+          do:
+            quoteGenerator.generate_random_quote:


quoteGenerator should be renamed to something like quote_generator.

tethryus

@dandenisa There are a few comments that need tp be handled, Please add a test for the overall flow.

tethryus · 2017-03-02T10:29:39Z

content/io/cloudslang/base/examples/yoda/samples.prop.sl

+#
+########################################################################################################################
+
+namespace: io.cloudslang.base.examples.properties


@dandenisa Please move the system properties file in configuration/properties/io/cloudslang/base/examples and update it`s reference where applied.

tethryus · 2017-03-02T10:52:06Z

content/io/cloudslang/base/examples/yoda/contains.sl

+namespace: io.cloudslang.base.examples.yoda
+
+decision:
+  name: contains


I think it would help out if this decision would be more generic, or use a different existing one to check for 'true' and 'false. @dandenisa WDYT?

there are couple of possibilities here: you can use an existing decision and do the check at step level or you can define a custom one like you did (if you happen to choose the second one, you should probably change the decision name / result - contains?)

levice14 · 2017-03-03T09:16:50Z

resources/base/examples/yoda/yoda_quotes.txt

@@ -0,0 +1 @@
+May the Force be with you;You will find only what you bring in;Size matters not;Do or do not. There is no try;The fear of loss is a path to the Dark Side;Truly wonderful the mind of a child is;Always two there are, no more, no less. A master and an apprentice;You must unlearn what you have learned;In a dark place we find ourselves, and a little more knowledge lights our way;Train yourself to let go of everything you fear to lose;Fear is the path to the dark side. Fear leads to anger, anger leads to hate, hate leads to suffering;Always pass on what you have learned;To be Jedi is to face the truth, and choose. Give off light, or darkness, Padawan. Be a candle, or the night;


maybe you could use newline separator here

@dandenisa WDYT?

levice14 · 2017-03-05T09:37:36Z

content/io/cloudslang/base/examples/yoda/generate_random_quote.sl

+          do:
+            math.random_number_generator:
+              - min: '0'
+              - max: ${str(len(read_text.strip().split(';')) - 2)}


Y the -2?

levice14 · 2017-03-05T09:38:57Z

content/io/cloudslang/base/examples/yoda/quote_check.sl

+########################################################################################################################
+#!!
+#! @description: The flow is based on a System Property file
+#! If it is set on true it displays the default quote, otherwise generates a random quote.


little more indentation please

levice14 · 2017-03-05T09:42:49Z

we will also need basic testing for these flows before merging

levice14 · 2017-03-10T08:10:31Z

any update on these flows? Can't wait to see it in master branch

Signed-off-by: Denisa Dan <[email protected]>

levice14 · 2017-04-04T13:41:48Z

@dandenisa what is the status of this PR?

branch is outdated with master - please update
builder output shows:

04:00:36 [INFO] ------------------------------------------------------------
04:00:36 [INFO] Following 173 executables do not have tests:
...
04:00:36 [INFO] - io.cloudslang.base.examples.yoda.print_image
04:00:36 [INFO] - io.cloudslang.base.examples.yoda.quote_check

we need to make sure we don;t introduce new uncovered items - opened related issue: #957

levice14 · 2017-04-04T13:46:11Z

test/io/cloudslang/base/examples/test_quote_check.sl

+    name: test_quote_check
+
+    inputs:
+      - default_quote:


the logic here is fishy - you say test_quote_check but you don;t invoke quote_check only a step from it? What do you intend to test with branch print_default_quote

levice14 · 2017-04-04T14:01:23Z

also, did you activate the new test suite?

Signed-off-by: Denisa Dan <[email protected]>

# Conflicts: # circle.yml

levice14 · 2017-05-22T06:58:01Z

test/io/cloudslang/base/examples/quote_check.inputs.yaml

+#
+########################################################################################################################
+testQuoteCheckSpTrue:
+  description: Tests that quote_check finishes with SUCCESS for the default case


@tethryus do we want these CRLF chars?

levice14 · 2017-05-22T06:58:45Z

great work @tethryus 👌

Signed-off-by: sorin <[email protected]>

Signed-off-by: Denisa Dan <[email protected]>

tethryus · 2017-08-04T11:51:55Z

Closing this PR. Will be added to the on boarding repository.

initial commit

d175c1f

oritstone added the status/in progress label Feb 28, 2017

levice14 assigned tethryus and levice14 Mar 1, 2017

levice14 requested review from tethryus and levice14 March 1, 2017 06:58

levice14 added this to the 1.1 milestone Mar 1, 2017

levice14 changed the title ~~Onboarding Flows~~ Onboarding Flows - Theme: Yoda Mar 1, 2017

tethryus suggested changes Mar 1, 2017

View reviewed changes

renamed directories and other small fixes

67e7ccb

tethryus suggested changes Mar 2, 2017

View reviewed changes

levice14 requested changes Mar 3, 2017

View reviewed changes

levice14 reviewed Mar 5, 2017

View reviewed changes

Modified PR after the request changes and added tests

05cebbb

Signed-off-by: Denisa Dan <[email protected]>

ghost force-pushed the onboardingFlows branch from 2330315 to 05cebbb Compare March 23, 2017 15:57

levice14 reviewed Apr 4, 2017

View reviewed changes

Modified test after PR

f780b8c

Signed-off-by: Denisa Dan <[email protected]>

ghost force-pushed the onboardingFlows branch 4 times, most recently from 53ed5be to 6be8554 Compare April 10, 2017 12:20

ghost force-pushed the onboardingFlows branch 2 times, most recently from 8350722 to e6d25f6 Compare April 10, 2017 12:40

Modify test so the input is read from a sp file

30a74eb

Signed-off-by: Denisa Dan <[email protected]>

ghost force-pushed the onboardingFlows branch 5 times, most recently from 29c011a to 701e559 Compare April 10, 2017 13:22

Modify test so the input is read from a sp file

a9b27e1

Signed-off-by: Denisa Dan <[email protected]>

ghost force-pushed the onboardingFlows branch from 701e559 to a9b27e1 Compare April 10, 2017 13:35

tethryus added 6 commits May 20, 2017 17:19

Merge branch 'master' into onboardingFlows

8cd584e

# Conflicts: # circle.yml

Solve conflicts

4ec552d

Removed test suites

c90ab4c

Test fix

427e132

Test fix

6b7e540

Merge branch 'master' into onboardingFlows

d390b7c

levice14 reviewed May 22, 2017

View reviewed changes

Change from CRLF to LF

aa97ed2

Signed-off-by: sorin <[email protected]>

levice14 approved these changes May 22, 2017

View reviewed changes

tethryus and others added 2 commits May 22, 2017 13:11

Merge branch 'master' into onboardingFlows

48e9ef5

Make descriptions more generic.

6a56c0c

Signed-off-by: Denisa Dan <[email protected]>

ghost force-pushed the onboardingFlows branch from 9c943a2 to 6a56c0c Compare May 29, 2017 15:10

tethryus added 2 commits June 2, 2017 03:09

Merge branch 'master' into onboardingFlows

10d0646

Merge branch 'master' into onboardingFlows

c1bf945

tethryus closed this Aug 4, 2017

tethryus deleted the onboardingFlows branch August 4, 2017 11:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Onboarding Flows - Theme: Yoda #946

Onboarding Flows - Theme: Yoda #946

ghost commented Feb 28, 2017 •

edited by ghost

Loading

levice14 commented Mar 1, 2017

levice14 commented Mar 1, 2017

tethryus commented Mar 1, 2017

tethryus left a comment

tethryus left a comment

tethryus Mar 1, 2017

tethryus Mar 1, 2017

tethryus Mar 1, 2017

tethryus Mar 1, 2017

tethryus Mar 1, 2017

tethryus Mar 1, 2017

tethryus left a comment

tethryus Mar 2, 2017

tethryus Mar 2, 2017

levice14 Mar 5, 2017

levice14 Mar 3, 2017

levice14 Apr 4, 2017

levice14 Mar 5, 2017

levice14 Mar 5, 2017

levice14 commented Mar 5, 2017

levice14 commented Mar 10, 2017

levice14 commented Apr 4, 2017

levice14 Apr 4, 2017

levice14 commented Apr 4, 2017

levice14 May 22, 2017

levice14 commented May 22, 2017

tethryus commented Aug 4, 2017

		@@ -0,0 +1 @@
		May the Force be with you;You will find only what you bring in;Size matters not;Do or do not. There is no try;The fear of loss is a path to the Dark Side;Truly wonderful the mind of a child is;Always two there are, no more, no less. A master and an apprentice;You must unlearn what you have learned;In a dark place we find ourselves, and a little more knowledge lights our way;Train yourself to let go of everything you fear to lose;Fear is the path to the dark side. Fear leads to anger, anger leads to hate, hate leads to suffering;Always pass on what you have learned;To be Jedi is to face the truth, and choose. Give off light, or darkness, Padawan. Be a candle, or the night;

Onboarding Flows - Theme: Yoda #946

Onboarding Flows - Theme: Yoda #946

Conversation

ghost commented Feb 28, 2017 • edited by ghost Loading

levice14 commented Mar 1, 2017

levice14 commented Mar 1, 2017

tethryus commented Mar 1, 2017

tethryus left a comment

Choose a reason for hiding this comment

tethryus left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tethryus left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

levice14 commented Mar 5, 2017

levice14 commented Mar 10, 2017

levice14 commented Apr 4, 2017

Choose a reason for hiding this comment

levice14 commented Apr 4, 2017

Choose a reason for hiding this comment

levice14 commented May 22, 2017

tethryus commented Aug 4, 2017

ghost commented Feb 28, 2017 •

edited by ghost

Loading