IME Support for WindowsDX build #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nightly build for this pull request:
|
Signed-off-by: 舰队的偶像-岛风酱! <[email protected]>
DX XNA (WinForms base) Only OGL UGL (SDL base) are not support Signed-off-by: 舰队的偶像-岛风酱! <[email protected]>
frg2089
force-pushed
the
feat/ime-preview
branch
from
17d1513 to
6fe7ef1
Compare
|
Ready for review but requires Rampastring/Rampastring.XNAUI#36 to be merged and released first |
Metadorius
reviewed
Feb 1, 2025
There was a problem hiding this comment.
Minor nitpicks.
@SadPencil @frg2089 I am not really knowledgeable about IME itself, so I'll leave that to you.
An issue should be created to track OpenGL and XNA builds IME status though.
ClientGUI/IME/IMEHandler.cs
Outdated
Comment on lines
115
to
117
| // The following code returns a more accurate location, aware of the input cursor | ||
| // However, it requires SetIMETextInputRectangle() be called whenever InputPosition is changed. | ||
| // And therefore, it's commented out for now. |
There was a problem hiding this comment.
Not clear why you can't just call that
There was a problem hiding this comment.
Comment updated.
If we apply this code, sometimes it's precise, other times it's worse than the inaccurate codes (due to outdated InputPosition). Such an inconsistent behavior is worse than a consistent but manageable inaccuracy.
|
Plan to hit the merge button after 24 hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 IME Support for WindowsDX only (WindowsXNA build also works, but occasionally it might have a chance to crash, so the IME support for WindowsXNA build has been disabled)
Close: #522
Link