Disable game lobby chat message audio when game is running

[11EJDE11]

As discussed somewhere on Discord.

[github-actions]

Nightly build for this pull request:

• artifacts-Ares.zip
• artifacts-YR.zip
• artifacts-TS.zip
  This comment is automatic and is meant to allow guests to get latest automatic builds without registering. It is updated on every successful build.

[Metadorius]

I am not sure that is a proper solution. You're trying to solve the problem of someone's spam coming through and repeatedly making sounds AFAIK, but you're also screwing up legit players chatting in the room when they, for example, didn't launch for some reason.

You should instead deal with the core issue, that is allowing to spam too many messages in a quick succession.

[11EJDE11]

Understood, yeah it is a rather pedestrian fix. I still think something like this could be wanted by some. The lag with IRC can be bad. There's also the case where two users get out of the game early and sit in the lobby talking; all remaining players in game can hear the beeps.

[Metadorius]

There's also the case where two users get out of the game early and sit in the lobby talking;

Is this a frequent/valid case? Genuine question since all my client exposure is from playing with a group of friends and not in FFA, so such never happened to me.

[11EJDE11]

We normally do 3v3 and 4v4 with a friendly bunch of lads so it's more common for us I would imagine.

Also to your point earlier - If the game fails to launch (anti virus blocking it for instance), or they quit out on the loading screen, the code to enable the audio will still run. I can't think of any cases where it wouldn't be enabled again.

[Metadorius]

How about a toggle in client options to control whether the chat sound is muted while in-game then?

[11EJDE11]

Sounds good to me. I'll look at into it when I get a mo.

[11EJDE11]

I've added a setting in. Figured while I was in there I should add some constants for control positioning - hope that's OK.

Before/After with these changes: