Add processor affinity argument for Ares#899
Draft
SadPencil wants to merge 2 commits intoCnCNet:developfrom
Draft
Add processor affinity argument for Ares#899SadPencil wants to merge 2 commits intoCnCNet:developfrom
SadPencil wants to merge 2 commits intoCnCNet:developfrom
Conversation
|
Nightly build for this pull request:
|
Metadorius
reviewed
Jan 4, 2026
Comment on lines
+162
to
+167
| if (overrideProcessorAffinity && ClientConfiguration.Instance.ClientGameType == ClientType.Ares) | ||
| { | ||
| // Ares defaults to use CPU 0 exclusively, unless explicitly overridden. | ||
| arguments += " " + "-AFFINITY:" + processorAffinity.ToString(CultureInfo.InvariantCulture); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
I am going to disappoint you: we can't really rely on this anymore with upcoming SyringeEx, because there command line params to be passed to the exe are defined as --args="-command -line -params".
Member
Author
|
Update: hold off this PR because it seems both the spawner and cnc-ddraw/ts-ddraw/ddrawcompat overrides the affinity mask. Currently this PR is only effective on Mental Omega 3.3.6 (Ares only, without phobos) and with old version ddrawcompat/without ddraw. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements CnCNet/cncnet-yr-client-package#793
Ref:
-AFFINITYcommand line argument cncnet-yr-client-package#793 (comment)-AFFINITYcommand line argument cncnet-yr-client-package#793 (comment)