Use composition mode for GameMode and Map

[SadPencil]

Previously on PR 719:

[SadPencil]

@Metadorius Is this what composition mode for? If so I think it is so dumb to copy-paste the boilerplate code twice

[github-actions]

Nightly build for this pull request:

• artifacts.zip
  This comment is automatic and is meant to allow guests to get latest automatic builds without registering. It is updated on every successful build.

[Metadorius]

@Metadorius Is this what composition mode for? If so I think it is so dumb to copy-paste the boilerplate code twice

I didn't mean you should "forward" things like this. Just write this.CommonConfig.XYZ when you need to access something

[SadPencil]

@Metadorius Is this what composition mode for? If so I think it is so dumb to copy-paste the boilerplate code twice

I didn't mean you should "forward" things like this. Just write this.CommonConfig.XYZ when you need to access something

This is ugly because we have GameModeMap.MaxPlayers (returns int), GameMode.MaxPlayers (returns int?), and Map.MaxPlayers (returns int?). Now two of the threes becomes this.CommonConfig.XYZ while the rest one stays in this.XYZ

Even defining an interface for CommonConfig does not solve this issue since GameModeMap has a different nullablity on these properties

xna-cncnet-client/DXMainClient/Domain/Multiplayer/GameModeMap.cs

Lines 76 to 85 in f1c2136

	public int MaxPlayers =>
	// Note: GameLobbyBase.GetMapList() assumes the priority.
	// If you have modified the expression here, you should also update GameLobbyBase.GetMapList().
	GameMode.MaxPlayersOverride ?? Map.MaxPlayers ?? GameMode.MaxPlayers ?? 0;
	public int MinPlayers =>
	GameMode.MinPlayersOverride ?? Map.MinPlayers ?? GameMode.MinPlayers ?? 0;
	public bool MultiplayerOnly =>
	Map.MultiplayerOnly ?? GameMode.MultiplayerOnly ?? false;

[Metadorius]

This is ugly because we have GameModeMap.MaxPlayers (returns int), GameMode.MaxPlayers (returns int?), and Map.MaxPlayers (returns int?). Now two of the threes becomes this.CommonConfig.XYZ while the rest one stays in this.XYZ

Even defining an interface for CommonConfig does not solve this issue since GameModeMap has a different nullablity on these properties

xna-cncnet-client/DXMainClient/Domain/Multiplayer/GameModeMap.cs

Lines 76 to 85 in f1c2136

	public int MaxPlayers =>
	// Note: GameLobbyBase.GetMapList() assumes the priority.
	// If you have modified the expression here, you should also update GameLobbyBase.GetMapList().
	GameMode.MaxPlayersOverride ?? Map.MaxPlayers ?? GameMode.MaxPlayers ?? 0;
	public int MinPlayers =>
	GameMode.MinPlayersOverride ?? Map.MinPlayers ?? GameMode.MinPlayers ?? 0;
	public bool MultiplayerOnly =>
	Map.MultiplayerOnly ?? GameMode.MultiplayerOnly ?? false;

solution: make a CommonConfig.Merge method that would return a merged config that you reference instead of individual things

[SadPencil]

This is ugly because we have GameModeMap.MaxPlayers (returns int), GameMode.MaxPlayers (returns int?), and Map.MaxPlayers (returns int?). Now two of the threes becomes this.CommonConfig.XYZ while the rest one stays in this.XYZ

Even defining an interface for CommonConfig does not solve this issue since GameModeMap has a different nullablity on these properties

xna-cncnet-client/DXMainClient/Domain/Multiplayer/GameModeMap.cs

Lines 76 to 85 in f1c2136

	public int MaxPlayers =>
	// Note: GameLobbyBase.GetMapList() assumes the priority.
	// If you have modified the expression here, you should also update GameLobbyBase.GetMapList().
	GameMode.MaxPlayersOverride ?? Map.MaxPlayers ?? GameMode.MaxPlayers ?? 0;
	public int MinPlayers =>
	GameMode.MinPlayersOverride ?? Map.MinPlayers ?? GameMode.MinPlayers ?? 0;
	public bool MultiplayerOnly =>
	Map.MultiplayerOnly ?? GameMode.MultiplayerOnly ?? false;

solution: make a CommonConfig.Merge method that would return a merged config that you reference instead of individual things

What do you mean? A CommonConfig and a MergedCommonConfig class? if not, how to make a different nullability?

[SadPencil]

Based on previous discussion shown below, this PR is now paused due to the nullability issue. This composition pattern brings some heavy usages of ! operator and therefore is a heavy load to maintain and makes our codes (files with #nullable enable) less reliable against null reference exception.