Adding Image Preview to CampaignSelector by BlackgamerzVN · Pull Request #939 · CnCNet/xna-cncnet-client

BlackgamerzVN · 2026-03-01T14:54:59Z

You can now add image preview for individual missions in Campaign Selection.

Example in CampaignSelector.ini:

[pnlMissionPreview]
Location=500,60
Size=350,200

'[pnlMissionPreview]' is not Visible by default. Set Visible=true to '[pnlMissionPreview]' to enable it:

[pnlMissionPreview]
Visible=true

To insert the image preview, create a new folder named "Mission Previews" inside "Resources" and put your mission preview images there.
Any image named "Default Preview.png" in "Mission Preview" folder will be automatically taken as default for missions without image preview

To define which Preview each mission will use, in Battle.ini:

[Mission]
...
PreviewImage=image.png
...

…-client into develop

github-actions · 2026-03-02T16:39:53Z

Nightly build for this pull request:

artifacts.zip
This comment is automatic and is meant to allow guests to get latest automatic builds without registering. It is updated on every successful build.

DXMainClient/DXGUI/Multiplayer/GameLobby/GameLobbyBase.cs

SadPencil · 2026-03-03T02:38:29Z

DXMainClient/DXMainClient.csproj

  <ItemGroup>
    <ProjectReference Include="..\ClientGUI\ClientGUI.csproj" />
    <ProjectReference Include="..\ClientUpdater\ClientUpdater.csproj" />
+    <ProjectReference Include="..\Rampastring.XNAUI\Rampastring.Tools\Rampastring.Tools.csproj" />


Is this modification intended, necessary, and related with the PR topic?

DXMainClient/DXGUI/Campaign/CampaignSelector.cs

SadPencil · 2026-03-03T02:42:57Z

DXMainClient/DXGUI/Campaign/CampaignSelector.cs

+            pnlMissionPreview = new XNAPanel(WindowManager);
+            pnlMissionPreview.Name = "pnlMissionPreview";
+            pnlMissionPreview.X = 500;
+            pnlMissionPreview.Y = 60;
+            pnlMissionPreview.Width = 350;
+            pnlMissionPreview.Height = 220;
+
+            // Use built-in background drawing
+            pnlMissionPreview.PanelBackgroundDrawMode =
+                PanelBackgroundImageDrawMode.STRETCHED;
+
+
+
+            AddChild(pnlMissionPreview);


Provide an example that this control is both optional and can be configured via ini. Update the document to contain the ini usage.

Please don't hit the resolve conversion button and leave it to the reviewer. This issue is not resolved because it seems this new panel is not optional -- instead of disabling it (you should) when such a panel does not exist, the panel is created

SadPencil · 2026-03-03T02:43:15Z

DXMainClient/Domain/Mission.cs

@@ -14,6 +15,8 @@

 using Rampastring.Tools;

+using static System.Collections.Specialized.BitVector32;


Is this modification intended, necessary, and related with the PR topic?

DXMainClient/Domain/Mission.cs

Cleaned up excess codes and finished the feature.

BlackgamerzVN

And done

DXMainClient/DXGUI/Multiplayer/GameLobby/GameLobbyBase.cs

DXMainClient/Domain/Mission.cs

DXMainClient/DXGUI/Campaign/CampaignSelector.cs

DXMainClient/DXGUI/Multiplayer/GameLobby/GameLobbyBase.cs

Made the panel optional for use (for real). Also enabled it to be displayed when the mission is not enabled.

SadPencil · 2026-03-04T05:48:14Z

DXMainClient/DXGUI/Campaign/CampaignSelector.cs

+                        pnlMissionPreview.BackgroundTexture.Dispose();
+
+                    pnlMissionPreview.BackgroundTexture = previewTexture;
+                    previewNeedsPreplace = true;


This line will not work since previewNeedsPreplace is a local variable (so the true value is not saved when leaving this method). You should try defining private bool pnlMissionPreviewTextureNeedsDispose = false as a class member

SadPencil · 2026-03-04T05:50:10Z

DXMainClient/DXGUI/Campaign/CampaignSelector.cs


+            string relativePath = Path.Combine("Resources", mission.PreviewImage);
+
+            if (File.Exists(relativePath))


Is this determination necessary? IIRC AssetLoader.LoadTextureUncached will return pink if relativePath does not exist (please check again)

SadPencil · 2026-03-04T05:52:18Z

DXMainClient/DXGUI/Campaign/CampaignSelector.cs

+        private void LoadPreview()
+        {
+            // find existing child first (the GUICreator/layout might already create it)
+            XNAPanel existingPanel = FindChild<XNAPanel>("pnlMissionPreview", true);


pnlMissionPreview = FindChild<XNAPanel>("pnlMissionPreview", optional: true); if (pnlMissionPreview != null) { ...

BlackgamerzVN · 2026-03-04T16:43:57Z

Is there still any need to make pnlMissionPreview togglable? Because apparently everything in CampaignSelector.cs uses hardcoded value now.
Though tbh, I don't think having them uses hardcoded value is a good idea. May I be allowed to unhardcode it and update it here in this PR?

SadPencil · 2026-03-05T00:15:40Z

Is there still any need to make pnlMissionPreview togglable? Because apparently everything in CampaignSelector.cs uses hardcoded value now. Though tbh, I don't think having them uses hardcoded value is a good idea. May I be allowed to unhardcode it and update it here in this PR?

how about this. you define a file name for the default mission preview image, and if this image does not exist, the mission preview is null and the size of tbMissionDescription etc. remains the old; if the image exists, define the mission preview and the new size of tbMissionDescription etc. to make some rooms

BlackgamerzVN · 2026-03-05T08:07:07Z

Lemme see if that can be done. For now I'm going to unhardcode controls first then put them in seperate PR before continuing on this.

BlackgamerzVN · 2026-03-05T16:36:56Z

Actually fuck it. Imma be done with this.

There isn't really a way to disable it per se. However it is now set to not be Visible by default (Which technically works).

Now Mission preview image are put into "Mission Previews" folder and defined in Battle.ini, whilst default preview image is also needed to be put into "Mission Previews" with an png named "Default Preview.png"

BlackgamerzVN · 2026-03-05T17:44:50Z

Is there still any need to make pnlMissionPreview togglable? Because apparently everything in CampaignSelector.cs uses hardcoded value now. Though tbh, I don't think having them uses hardcoded value is a good idea. May I be allowed to unhardcode it and update it here in this PR?

how about this. you define a file name for the default mission preview image, and if this image does not exist, the mission preview is null and the size of tbMissionDescription etc. remains the old; if the image exists, define the mission preview and the new size of tbMissionDescription etc. to make some rooms

Been thinking about it. I don't think it really pan well for someone who has custom Campaign Preview setup. For now I can make it Visible=false by default.

Will update description later.

Replaced previewNeedsPreplace with pnlMissionPreviewTextureNeedsDispose and making pnlMissionPreviewTextureNeedsDispose a class member

BlackgamerzVN · 2026-03-06T12:02:45Z

I think that's pretty much it

SadPencil · 2026-03-07T02:49:03Z

Is there still any need to make pnlMissionPreview togglable? Because apparently everything in CampaignSelector.cs uses hardcoded value now. Though tbh, I don't think having them uses hardcoded value is a good idea. May I be allowed to unhardcode it and update it here in this PR?

how about this. you define a file name for the default mission preview image, and if this image does not exist, the mission preview is null and the size of tbMissionDescription etc. remains the old; if the image exists, define the mission preview and the new size of tbMissionDescription etc. to make some rooms

Been thinking about it. I don't think it really pan well for someone who has custom Campaign Preview setup. For now I can make it Visible=false by default.

Will update description later.

Can you detail why the approach is not well?

SadPencil · 2026-03-07T02:50:44Z

DXMainClient/DXGUI/Campaign/CampaignSelector.cs

        public override void Initialize()
        {
+            // Read customizable window size from the campaign settings INI (fall back to defaults)
+            var settingsIni = new IniFile(SafePath.CombineFilePath(ProgramConstants.GamePath, SETTINGS_PATH));


This is not the way we read a configuration.

Also, is it really infeasible to optionally enable the preview and resize the mission description panel? No one should expect an overlap between the preview and the mission description.

Assuming image preview panel is to have 1/3 of the mission description panel's height, resize said description panel and place it at the bottom. would need to be properly scaled to 1:1 like with Skirmish and Multiplayer Lobby for starter, othersize it won't look well being stretched. And it doesn't take into account where mission description text may go pass that description panel.

Though I can place the mission preview at the bottom of campaign list then resize the campaign list instead to accomodate the mission preview like DTA. It's simpler to be done that way.

would need to be properly scaled to 1:1 like with Skirmish and Multiplayer Lobby for starter, othersize it won't look well being stretched

Yes. What's the issue?

And it doesn't take into account where mission description text may go pass that description panel.

If the preview panel is enabled and the mission list is not resized, where should the panel be placed? and will the description text go pass the panel? I think yes the text will go pass the panel and thus it is also unexpected

btw in case there is some misunderstanding -- we are talking about the default config right? the whole components can be configured via ini

SadPencil · 2026-03-07T02:51:08Z

DXMainClient/DXGUI/Campaign/CampaignSelector.cs

+            ClientRectangle = new Rectangle(
+                0, 
+                0,
+                DEFAULT_WIDTH, 
+                DEFAULT_HEIGHT);
            BorderColor = UISettings.ActiveSettings.PanelBorderColor;


Do not make format-only changes unless you have significantly modified this file -- which is not

My bad, I'll clean it up now.

BlackgamerzVN added 4 commits March 1, 2026 20:02

Campaign Preview

5592706

Merge branch 'develop' of https://github.com/BlackgamerzVN/xna-cncnet…

3f6eb98

…-client into develop

Fixes the failure in image previewing

3f9a67a

Patch CS0117 error

2161634

SadPencil requested changes Mar 3, 2026

View reviewed changes

BlackgamerzVN added 2 commits March 3, 2026 20:00

Finish touch on Campaign Preview features

9341760

Cleaned up excess codes and finished the feature.

Small fix

174a19d

BlackgamerzVN requested a review from SadPencil March 3, 2026 14:18

BlackgamerzVN commented Mar 3, 2026

View reviewed changes

DXMainClient/DXGUI/Multiplayer/GameLobby/GameLobbyBase.cs Outdated Show resolved Hide resolved

DXMainClient/Domain/Mission.cs Outdated Show resolved Hide resolved

BlackgamerzVN marked this pull request as ready for review March 3, 2026 15:00

SadPencil requested changes Mar 3, 2026

View reviewed changes

DXMainClient/DXGUI/Campaign/CampaignSelector.cs Outdated Show resolved Hide resolved

DXMainClient/DXGUI/Campaign/CampaignSelector.cs Outdated Show resolved Hide resolved

DXMainClient/DXGUI/Campaign/CampaignSelector.cs Outdated Show resolved Hide resolved

MahBoiDeveloper requested changes Mar 3, 2026

View reviewed changes

DXMainClient/DXGUI/Multiplayer/GameLobby/GameLobbyBase.cs Outdated Show resolved Hide resolved

BlackgamerzVN added 3 commits March 4, 2026 12:31

Feature made optional

61c971f

Made the panel optional for use (for real). Also enabled it to be displayed when the mission is not enabled.

Revert GameLobbyBase change (again)

79dba29

Merge branch 'CnCNet:develop' into develop

c31f6fb

SadPencil requested changes Mar 4, 2026

View reviewed changes

Migration to latest client ver. Currently not functioning properly.

9cac493

BlackgamerzVN added 5 commits March 6, 2026 00:09

Readjusted INI. Made pnlMissionPreview not visible by default.

5c8306e

There isn't really a way to disable it per se. However it is now set to not be Visible by default (Which technically works).

Merge branch 'develop' into CampaignPreview

dc3521a

Update CampaignSelector.cs

39cff9e

Resolve merging errors

1ab0145

Renew preview image path definition

4395a5d

Now Mission preview image are put into "Mission Previews" folder and defined in Battle.ini, whilst default preview image is also needed to be put into "Mission Previews" with an png named "Default Preview.png"

BlackgamerzVN added 2 commits March 6, 2026 18:06

Small update

cbf4f5c

Another minor fix

4389528

Replaced previewNeedsPreplace with pnlMissionPreviewTextureNeedsDispose and making pnlMissionPreviewTextureNeedsDispose a class member

SadPencil requested changes Mar 7, 2026

View reviewed changes

		@@ -14,6 +15,8 @@

		using Rampastring.Tools;

		using static System.Collections.Specialized.BitVector32;


		string relativePath = Path.Combine("Resources", mission.PreviewImage);

		if (File.Exists(relativePath))

Uh oh!

Conversation

BlackgamerzVN commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SadPencil Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BlackgamerzVN left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BlackgamerzVN commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SadPencil commented Mar 5, 2026

Uh oh!

BlackgamerzVN commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BlackgamerzVN commented Mar 5, 2026

Uh oh!

BlackgamerzVN commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BlackgamerzVN commented Mar 6, 2026

Uh oh!

SadPencil commented Mar 7, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

BlackgamerzVN commented Mar 1, 2026 •

edited

Loading

github-actions bot commented Mar 2, 2026 •

edited

Loading

SadPencil Mar 3, 2026 •

edited

Loading

BlackgamerzVN commented Mar 4, 2026 •

edited

Loading

BlackgamerzVN commented Mar 5, 2026 •

edited

Loading

BlackgamerzVN commented Mar 5, 2026 •

edited

Loading