-
Notifications
You must be signed in to change notification settings - Fork 14
Staging #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging #136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just few tasteful changes
if (subject) { | ||
console.log("this madafaka useeffect") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bro, this do be public
function weAdding<dunno>( | ||
event: React.MouseEvent, | ||
mainstuff: dunno, | ||
selectedStuff: dunno[], | ||
setSelectedStuff: React.Dispatch<React.SetStateAction<dunno[]>>, | ||
) { | ||
event.stopPropagation(); | ||
if (!selectedStuff.includes(mainstuff)) { | ||
setSelectedStuff((prevItems) => [...prevItems, mainstuff]); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please name this better
function removeThis<dunno>( | ||
event: React.MouseEvent, | ||
mainStuff: dunno, | ||
selectedStuff: dunno[], | ||
setSelectedStuff: React.Dispatch<React.SetStateAction<dunno[]>>, | ||
) { | ||
event.stopPropagation(); | ||
if (selectedStuff.includes(mainStuff)) { | ||
setSelectedStuff( | ||
selectedStuff.filter((el) => { | ||
return el != mainStuff; | ||
}), | ||
); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again, my brain at 3 AM can't tell what is it
hope i did not break anything pwees check once
added the sidebar #119
not optimized but it is working for now
will do more tomorrow :)
for now - not responsive, search bar styling is not done, gonna make it sticky, i dunno why it is loading each time we click on a filter even before clicking on apply filters, will look into that as well.