Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CEUndoManager grouping #69

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

hi2gage
Copy link
Contributor

@hi2gage hi2gage commented Feb 10, 2025

Description

Fixes #68

DelegatedUndoManager does not override

func beginUndoGrouping()
func endUndoGrouping()

so calling

textView.undoManager?.beginUndoGrouping()

here and here does not undo as group as expected.

I also updated the names to match between the CEUndoManager and UndoManager.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Before:

CEUndoManager_before.mov

After:

CEUndoManager_after.mov

@hi2gage hi2gage changed the title Fix ce undo manager grouping Fix CEUndoManager grouping Feb 10, 2025
Copy link
Contributor

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, looks good!

@thecoolwinter thecoolwinter merged commit 227cd4e into CodeEditApp:main Feb 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 DelegatedUndoManager undo groups not working as expected
3 participants