role already exist fix

Author: jaspreetpromail

ecs-fargate-wordpress-rds-terraform/ecs.tf

@@ -1,5 +1,5 @@
 resource "aws_ecs_cluster" "default" {
-  name = var.ecs_cluster_name
+    name = "${var.ecs_cluster_name}"
 }
 
 resource "aws_cloudwatch_log_group" "ecs_log_group" {
@@ -12,8 +12,14 @@ resource "aws_cloudwatch_log_group" "ecs_log_group" {
   }
 }
 
+data "aws_iam_role" "existing_ecs_task_execution_role" {
+  name = "ecsTaskExecutionRole"
+}
+
 resource "aws_iam_role" "ecs_task_execution_role" {
-  name = "ecsTaskExecutionRole-tf"
+  count = length(data.aws_iam_role.existing_ecs_task_execution_role.arn) == 0 ? 1 : 0
+
+  name = "ecsTaskExecutionRole"
 
   assume_role_policy = jsonencode({
     Version = "2012-10-17"
@@ -30,19 +36,21 @@ resource "aws_iam_role" "ecs_task_execution_role" {
 }
 
 resource "aws_iam_role_policy_attachment" "ecs_task_execution_role_policy" {
-  role       = aws_iam_role.ecs_task_execution_role.name
+  count = length(data.aws_iam_role.existing_ecs_task_execution_role.arn) == 0 ? 1 : 0
+
+  role       = aws_iam_role.ecs_task_execution_role[count.index].name
   policy_arn = "arn:aws:iam::aws:policy/service-role/AmazonECSTaskExecutionRolePolicy"
 }
 
 resource "aws_ecs_task_definition" "wordpress" {
-  family                   = "wp-ecs-task-tf"
-  container_definitions    = data.template_file.wp-container.rendered
+  family                = "wp-ecs-task-tf"
+  container_definitions = data.template_file.wp-container.rendered
   requires_compatibilities = ["FARGATE"]
-  network_mode             = "awsvpc"
-  cpu                      = 512
-  memory                   = 1024
+  network_mode          = "awsvpc"
+  cpu                   = 512
+  memory                = 1024
 
-  execution_role_arn = aws_iam_role.ecs_task_execution_role.arn
+  execution_role_arn = length(data.aws_iam_role.existing_ecs_task_execution_role.arn) == 0 ? aws_iam_role.ecs_task_execution_role[0].arn : data.aws_iam_role.existing_ecs_task_execution_role.arn
 
   runtime_platform {
     operating_system_family = "LINUX"
@@ -51,21 +59,21 @@ resource "aws_ecs_task_definition" "wordpress" {
 }
 
 resource "aws_ecs_service" "wp-ecs-svc" {
-  name            = "wp-ecs-svc-tf"
-  cluster         = aws_ecs_cluster.default.id
-  task_definition = aws_ecs_task_definition.wordpress.arn
-  desired_count   = 1
-  launch_type     = "FARGATE"
+    name = "wp-ecs-svc-tf"
+    cluster = "${aws_ecs_cluster.default.id}"
+    task_definition = "${aws_ecs_task_definition.wordpress.arn}"
+    desired_count = 1
+    launch_type = "FARGATE"
+    
+    load_balancer {
+        target_group_arn = "${aws_lb_target_group.default.arn}"
+        container_name = "wordpress"
+        container_port = 80
+    }
 
-  load_balancer {
-    target_group_arn = aws_lb_target_group.default.arn
-    container_name   = "wordpress"
-    container_port   = 80
-  }
-
-  network_configuration {
-    subnets          = [aws_subnet.wp-public-a-tf.id, aws_subnet.wp-public-b-tf.id, aws_subnet.wp-public-c-tf.id]
-    security_groups  = [aws_security_group.wp-alb-tf.id]
-    assign_public_ip = true
-  }
+    network_configuration {
+        subnets             = ["${aws_subnet.wp-public-a-tf.id}", "${aws_subnet.wp-public-b-tf.id}", "${aws_subnet.wp-public-c-tf.id}"]
+        security_groups     = ["${aws_security_group.wp-alb-tf.id}"]
+        assign_public_ip    = true
+    }
 }

ecs-fargate-wordpress-rds-terraform/variables.tf

@@ -1,3 +1,8 @@
+variable "region" {
+  description = "AWS Region"
+  default     = "your-region"
+}
+
 variable "aws_access_key" {
   description = "AWS access key"
   default = "your-access-key"
@@ -8,26 +13,6 @@ variable "aws_secret_key" {
   default = "your-secret-key"
 }
 
-variable "region" {
-  description = "AWS Region"
-  default     = "us-east-1"
-}
-
-variable "zone1" {
-  description = "AWS Zone 1"
-  default     = "us-east-1a"
-}
-
-variable "zone2" {
-  description = "AWS Zone 2"
-  default     = "us-east-1b"
-}
-
-variable "zone3" {
-  description = "AWS Zone 3"
-  default     = "us-east-1c"
-}
-
 // VPC
 variable "vpc_cidr_block" {
   description = "VPC network"

ecs-fargate-wordpress-rds-terraform/vpc.tf

@@ -21,7 +21,7 @@ resource "aws_internet_gateway" "default" {
 resource "aws_subnet" "wp-public-a-tf" {
     vpc_id            = "${aws_vpc.default.id}"
     cidr_block        = "${var.public_subnet_a_cidr_block}"
-    availability_zone = "${var.zone1}"
+    availability_zone = "${var.region}a"
 
     tags = {
        Name = "wp-public-a-tf"
@@ -31,7 +31,7 @@ resource "aws_subnet" "wp-public-a-tf" {
 resource "aws_subnet" "wp-public-b-tf" {
     vpc_id            = "${aws_vpc.default.id}"
     cidr_block        = "${var.public_subnet_b_cidr_block}"
-    availability_zone = "${var.zone2}"
+    availability_zone = "${var.region}b"
 
     tags = {
        Name = "wp-public-b-tf"
@@ -41,7 +41,7 @@ resource "aws_subnet" "wp-public-b-tf" {
 resource "aws_subnet" "wp-public-c-tf" {
     vpc_id            = "${aws_vpc.default.id}"
     cidr_block        = "${var.public_subnet_c_cidr_block}"
-    availability_zone = "${var.zone3}"
+    availability_zone = "${var.region}c"
 
     tags = {
        Name = "wp-public-c-tf"