London | Elhadj Abdoul Diallo | Module-Tools | WEEK4 - Implement-shell-tools-python #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
March 5, 2025 16:00
…mprove formatting in ls command
…line extraction in output function
…cter count in wc command
…ction accordingly
…le paths in output
…eamline output for single file paths
… counts for multiple files
added 7 commits
March 6, 2025 15:34
…based on selected flags
eediallo
changed the title
eediallo
changed the title
jeremycward
reviewed
Apr 26, 2025
| return lines | ||
|
|
||
| def output_lines_with_numbers(lines): | ||
| count = 0 |
There was a problem hiding this comment.
possibly rename 'number1' and 'number2 ' to 'line_number_on' and filter_empty_lines'
jeremycward
reviewed
Apr 26, 2025
| print(file, end=' ') | ||
| if not is_file_per_line_option: | ||
| print() | ||
|
|
There was a problem hiding this comment.
would good be a good idea, rather than printing directly to console, to add console lines to an in memory list, this would make it easier to direct the output whereever you want it, and to test.
For example, 'print' could be replaced by your own output function, like 'outputline', which either printed to console, or an in memory list. Then in python, you could monkey patch the 'outputline' function.
jeremycward
reviewed
Apr 26, 2025
| elif is_words_option: print(words_count, file_path) | ||
| elif is_chars_option: print(chars_count, file_path) | ||
| else: print(lines_count, words_count, chars_count, file_path) | ||
|
|
There was a problem hiding this comment.
have a look at tuples rather than a plain array for the count results
jeremycward
approved these changes
Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist