London | Elhadj Abdoul Diallo | Module-Tools | WEEK4 - Implement-shell-tools-python #38
Conversation
…mprove formatting in ls command
…line extraction in output function
…cter count in wc command
…ction accordingly
…le paths in output
…eamline output for single file paths
… counts for multiple files
…based on selected flags
eediallo
changed the title
eediallo
changed the title
| return lines | ||
|
|
||
| def output_lines_with_numbers(lines): | ||
| count = 0 |
There was a problem hiding this comment.
possibly rename 'number1' and 'number2 ' to 'line_number_on' and filter_empty_lines'
| print(file, end=' ') | ||
| if not is_file_per_line_option: | ||
| print() | ||
|
|
There was a problem hiding this comment.
would good be a good idea, rather than printing directly to console, to add console lines to an in memory list, this would make it easier to direct the output whereever you want it, and to test.
For example, 'print' could be replaced by your own output function, like 'outputline', which either printed to console, or an in memory list. Then in python, you could monkey patch the 'outputline' function.
There was a problem hiding this comment.
that's a really interesting point @jeremycward ! thank you !
| elif is_words_option: print(words_count, file_path) | ||
| elif is_chars_option: print(chars_count, file_path) | ||
| else: print(lines_count, words_count, chars_count, file_path) | ||
|
|
There was a problem hiding this comment.
have a look at tuples rather than a plain array for the count results
|
Hey @jeremycward ! Thank you very much for reviewing my code. Could you please add a complete label to this PR? |
|
Done, I think . Please let me know if you need me to do anything further.
On Monday 28 April 2025 at 09:35:03 BST, Elhadj Abdoul Diallo ***@***.***> wrote:
eediallo left a comment (CodeYourFuture/Module-Tools#38)
Hey @jeremycward ! Thank you very much for reviewing my code. Could you please add a complete label to this PR?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
jeremycward
added
🐂 Size Medium
Learners, PR Template
Self checklist