London SDC | Anna Fedyna | Module Tools| Individual shell | Week 1 #40
Conversation
There was a problem hiding this comment.
This is a great submission that demonstrates good engagement and understanding of each of the programs that you were working with, as well as great Bash scripting skills. There are a few comments where your attention to detail could be improved, it's always prudent to double check the output of your scripts to make sure that they match the specifications ahead of submitting your work for review.
Overall a very solid effort and great work!
| @@ -4,3 +4,6 @@ set -euo pipefail | |||
|
|
|||
| # TODO: Write a command to output every line in dialogue.txt that does not contain the word "Hello" (regardless of case). | |||
| # The output should contain 10 lines. | |||
|
|
|||
| grep -vic 'Hello' dialogue.txt | |||
There was a problem hiding this comment.
issue: We're using grep twice here, and the output on one is 10 lines and the output on the other is 1 line. We can definitely do this correctly in one, can you work out which flag (or flags) we might need to do this?
There was a problem hiding this comment.
Probably, leaving -vi flags going to be enough. If there is any other way would be nice to now)
ehwus
added
Complete
|
@ehwus Thank you a lot for the review! I really appreciate valuable feedback ! |
annafedyna
force-pushed
the
individual-shell
branch
from
fb1b2ca to
025ce94
Compare
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.