-
-
Notifications
You must be signed in to change notification settings - Fork 11
LONDON SDC | Anna Fedyna | Module-Tools | Week 3 | Implemented Shell Commands in JS #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
LONDON SDC | Anna Fedyna | Module-Tools | Week 3 | Implemented Shell Commands in JS #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great effort Anna that shows a good understanding of creating command line programs in Node, as well as good knowledge of the shell programs themselves. Formatting your code would make it easier to read and should be quite easy for you to set up, and working with data like files it's always important to be mindful of the operations we are making - always be thinking whether we can iterate fewer times, as when the files are large these can be very costly operations.
@ehwus Thank you for your review! I really appreciate you highlighting important moments that need more attention. |
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.