Skip to content

LONDON SDC | Anna Fedyna | Module-Tools | Week 3 | Implemented Shell Commands in JS #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

annafedyna
Copy link

@annafedyna annafedyna commented Mar 20, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@annafedyna annafedyna added the Needs Review Participant to add when requesting review label Mar 21, 2025
@ehwus ehwus added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Mar 29, 2025
Copy link

@ehwus ehwus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great effort Anna that shows a good understanding of creating command line programs in Node, as well as good knowledge of the shell programs themselves. Formatting your code would make it easier to read and should be quite easy for you to set up, and working with data like files it's always important to be mindful of the operations we are making - always be thinking whether we can iterate fewer times, as when the files are large these can be very costly operations.

@ehwus ehwus added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 29, 2025
@annafedyna
Copy link
Author

annafedyna commented Mar 29, 2025

@ehwus Thank you for your review! I really appreciate you highlighting important moments that need more attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants