LONDON SDC | Pooriya Ketabi | Module-Tools | Sprint-2 | Shell pipelines exercises#57
Open
PooriyaKTB wants to merge 13 commits intoCodeYourFuture:mainfrom
Open
LONDON SDC | Pooriya Ketabi | Module-Tools | Sprint-2 | Shell pipelines exercises#57PooriyaKTB wants to merge 13 commits intoCodeYourFuture:mainfrom
PooriyaKTB wants to merge 13 commits intoCodeYourFuture:mainfrom
Conversation
PooriyaKTB
added
the
Needs Review
illicitonion
reviewed
Apr 4, 2025
Member
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
Looking good! I left a couple of comments :)
Comment on lines
7
to
+8
| # It should be clear from your script's output that there have been 5 Entry events and 4 Exit events. | ||
| sort events.txt | uniq -c No newline at end of file |
Member
There was a problem hiding this comment.
I'm not sure this quite answers the question - the prompt is that it should be clear that there are 5 Entry events and 4 Exit events, but the output of this is:
2 Entry German
1 Entry Mariana
2 Entry Sally
1 Exit German
1 Exit Mariana
2 Exit Sally
I can add those numbers up myself to get to 5 and 4, but ideally the script you produce would do that for me?
| # TODO: Write a command to show how many times anyone has entered and exited. | ||
| # It should be clear from your script's output that there have been 5 Entry events and 4 Exit events. | ||
| # The word "Event" should not appear in your script's output. | ||
| echo "Entry:" |
Member
There was a problem hiding this comment.
This works, but isn't super general - imagine in the future a new event type got added, perhaps "Refused" - can you rewrite this so that it will work for any events that happen, not just Entry and Exit?
illicitonion
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.