Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable other settings tabs when image handling is disabled & improve UI #908

Merged
merged 5 commits into from
Apr 7, 2025

Conversation

abaicus
Copy link
Contributor

@abaicus abaicus commented Apr 3, 2025

All Submissions:

Changes proposed in this Pull Request:

  • Disables other settings tabs when image handling is turned off;
  • Cards on the main dashboard page should link to the general tab if image handling is turned off;
  • Makes the statuses of the Optimization Status card update live based on current settings (no need to save now);
  • Fixes consistency in styling and layout for the sidebar cards;
  • Makes the connection details card more compact;

image
image

Closes Codeinwp/optimole-service#1386.

How to test the changes in this Pull Request:

  1. Disable image handling in the general tab, this will also disable other tabs than General;
  2. Cards on the main dashboard page pointing to Enable Offload Images& Advanced Settings should just switch to General tab;
  3. The Optimization Status card should react to setting changes instantly;

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@pirate-bot
Copy link
Collaborator

pirate-bot commented Apr 3, 2025

Plugin build for fc9ffda is ready 🛎️!

@abaicus abaicus changed the title feat: disable other settings tabs when image handling is disabled [closes Codeinwp/optimole-service#1386] feat: disable other settings tabs when image handling is disabled & improve UI Apr 3, 2025
@selul selul merged commit 2b246ef into development Apr 7, 2025
11 checks passed
@selul selul deleted the prf/disable-settings branch April 7, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants