Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/cr 10/drop down #4

Merged
merged 13 commits into from
Oct 18, 2024
Merged

Feat/cr 10/drop down #4

merged 13 commits into from
Oct 18, 2024

Conversation

yulrang
Copy link
Contributor

@yulrang yulrang commented Oct 17, 2024

๐Ÿ”– Issue Ticket

Ticket

โœ๏ธ Description

Dropdown variant prop ์ถ”๊ฐ€

  • ์ง€์—ญ ์ „์ฒด
  • ์นดํ…Œ๊ณ ๋ฆฌ ์ „์ฒด
  • ๋งˆ๊ฐ ์ž„๋ฐ•์ˆœ/์ฐธ์—ฌ ์ธ์›์ˆœ ์ •๋ ฌ

โœ… Checklist

PR

  • Branch Convention ํ™•์ธ

    feat/ ํ”ผ์ณ, fix/ ๋ฒ„๊ทธ ์ˆ˜์ •, refactor/ ๊ฐœ์„ 

  • Base Branch ํ™•์ธ
  • ์ ์ ˆํ•œ Label ์ง€์ •
  • Assignee ๋ฐ Reviewer ์ง€์ •

Test

  • ๋กœ์ปฌ ์ž‘๋™ ํ™•์ธ
    Screenshot 2024-10-17 at 18 29 23

Copy link
Contributor

@HaeJungg HaeJungg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜๊ณ ํ•˜์Žณ์Šด๋‹ˆ๋‹ค๐Ÿ‘

@@ -6,7 +6,7 @@
"dev": "next dev",
"build": "next build",
"start": "next start",
"lint": "eslint src/**/*.{ts,tsx,js,jsx}",
"lint": "eslint --fix --no-cache src/**/*.{ts,tsx,js,jsx}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix๋ž‘ ์บ์‹œ์‚ญ์ œ ๋งค๋ฒˆ ๋ช…๋ น์–ด๋กœ ํ–ˆ๋Š”๋ฐ ์ถ”๊ฐ€ํ•ด์ฃผ์…จ๊ตฐ์š”!๐Ÿ‘

@yulrang yulrang merged commit d122096 into develop Oct 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants