Skip to content

Translating to Portuguese from Brazil (pt-br) the file localization.json #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2017

Conversation

OtacilioN
Copy link
Collaborator

Hey folks,

I really liked the project, and i want to contribute translating the project to portuguese from Brazil, the pt-br, which is a little bit different from the original portuguese in Portugal, the PT. So i made this pull request translating the file localization.json.

}
},
"quiz": {
"before": {
"en": "Regular Expression: ",
"de": "Regulärer Ausdruck: ",
"sv": "Reguljärt uttryck: "
"sv": "Reguljärt uttryck: ".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating the PR and starting the translation effort!
In this line, I believe, there must be a comma "," instead of a dot.

}
},
"license": {
"en": "<span xmlns:dct='http://purl.org/dc/terms/' href='http://purl.org/dc/dcmitype/InteractiveResource' property='dct:title' rel='dct:type'>Regex Tutorial</span> by <span xmlns:cc='http://creativecommons.org/ns#' property='cc:attributionName'>Nicco Kunzmann</span> is licensed under a <a rel='license' href='http://creativecommons.org/licenses/by/4.0/'>Creative Commons Attribution 4.0 International License</a>.",
"de": "<span xmlns:dct='http://purl.org/dc/terms/' href='http://purl.org/dc/dcmitype/InteractiveResource' property='dct:title' rel='dct:type'>Regex-Tutorial</span> von <span xmlns:cc='http://creativecommons.org/ns#' property='cc:attributionName'>Nicco Kunzmann</span> ist lizenziert unter einer <a rel='license' href='http://creativecommons.org/licenses/by-sa/4.0/'>Creative Commons Namensnennung - Weitergabe unter gleichen Bedingungen 4.0 International Lizenz</a>.",
"sv": "<span xmlns:dct='http://purl.org/dc/terms/' href='http://purl.org/dc/dcmitype/InteractiveResource' property='dct:title' rel='dct:type'>Regex Tutorial</span> av <span xmlns:cc='http://creativecommons.org/ns#' property='cc:attributionName'>Nicco Kunzmann</span> är licenserad under en <a rel='license' href='http://creativecommons.org/licenses/by/4.0/'>Creative Commons Erkännande 4.0 Internationell Licens</a>."
"sv": "<span xmlns:dct='http://purl.org/dc/terms/' href='http://purl.org/dc/dcmitype/InteractiveResource' property='dct:title' rel='dct:type'>Regex Tutorial</span> av <span xmlns:cc='http://creativecommons.org/ns#' property='cc:attributionName'>Nicco Kunzmann</span> är licenserad under en <a rel='license' href='http://creativecommons.org/licenses/by/4.0/'>Creative Commons Erkännande 4.0 Internationell Licens</a>.",
"pt-br": "<span xmlns:dct='http://purl.org/dc/terms/' href='http://purl.org/dc/dcmitype/InteractiveResource' property='dct:title' rel='dct:type'>Regex Tutorial</span> por <span xmlns:cc='http://creativecommons.org/ns#' property='cc:attributionName'>Nicco Kunzmann</span> está licenciado sob a <a rel='license' href='http://creativecommons.org/licenses/by/4.0/'>Creative Commons Atribuições 4.0 Licença Internacional </a>."
Copy link
Member

@niccokunzmann niccokunzmann Sep 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you like, you are welcome to add your name to the license of your translation.

@niccokunzmann
Copy link
Member

@OtacilioN Thanks for your active feedback in form of a pull-request!
The build failed. The error message is here:
https://travis-ci.org/CoderDojoPotsdam/regex-tutorial/builds/274464400#L1114
I left a comment, why I think this happens.

Would you like to change the file again?

I appreciate the change of this one file as I think this is the right way to go for translating: small steps so that others can join.

@OtacilioN
Copy link
Collaborator Author

@niccokunzmann sure! I'll fix the problems and submite e new Pull Request right now!

@OtacilioN
Copy link
Collaborator Author

Okay, done! Now Travis CI is building.

@niccokunzmann niccokunzmann merged commit 3f7dfc2 into CoderDojoPotsdam:master Sep 12, 2017
@niccokunzmann
Copy link
Member

Thanks!

@OtacilioN
Copy link
Collaborator Author

Hey @niccokunzmann what is the next step?

@niccokunzmann
Copy link
Member

You can start by translating the first file here:
https://github.com/CoderDojoPotsdam/regex-tutorial/tree/master/en
You can create a folder for your language and copy the English or German language over to a new folder with your language code.

Translating does not mean that you need to stay close to the source. You can add your ideas, jokes, .... and give feedback if anything in the source language could better.

What do you think? I am here if you like to ask something.

@OtacilioN
Copy link
Collaborator Author

Hey @niccokunzmann sorry for the delay, i will start the translations of this files now, thanks for your suport!

@niccokunzmann
Copy link
Member

Hi, all fine. I added a Gitter chat in case an issue is not the means to communicate. https://gitter.im/regex-tutorial

@niccokunzmann
Copy link
Member

niccokunzmann commented Sep 25, 2017

https://github.com/CoderDojoPotsdam/regex-tutorial/invitations I added you to the collaborators in case you like to work with others on the project and merge their work while I am not here. If you like, you can also merge #105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants