Skip to content

Conversation

@psychology50
Copy link
Member

μž‘μ—… 이유

  • I made a mistake to implement API where updating the chat room information due to the complexity of various scenarios:
origin image βœ… origin image ❌
non-image Delete original image Do nothing
new-image Delete original image, and copy new image Copy new image
exist-image Only check object existence ❌
  • However, I was only handling background images with values of null or those starting with the /delete prefix.

μž‘μ—… 사항

  • Removed the @Pattern annotation in ChatRoomReq.Update.
  • Added the required logic in the ChatRoomPatchHelper.

리뷰어가 μ€‘μ μ μœΌλ‘œ 확인해야 ν•˜λŠ” λΆ€λΆ„

  • none

λ°œκ²¬ν•œ 이슈

  • I also forgot to include the chat member's profile image in the chat member response. ....^^

@psychology50 psychology50 added bug κΈ΄κΈ‰ν•˜κ³ , μ€‘μš”λ„κ°€ 높은 이슈 fix κΈ°λŠ₯ μˆ˜μ • labels Jan 23, 2025
@psychology50 psychology50 self-assigned this Jan 23, 2025
@psychology50 psychology50 merged commit 4ee1d56 into dev Jan 23, 2025
1 check passed
@psychology50 psychology50 deleted the fix/update-chatroom-background-img branch January 23, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug κΈ΄κΈ‰ν•˜κ³ , μ€‘μš”λ„κ°€ 높은 이슈 fix κΈ°λŠ₯ μˆ˜μ •

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants