feat: add terminal formatter #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Colonial-Dev
reviewed
Sep 5, 2024
Colonial-Dev
reviewed
Sep 5, 2024
Colonial-Dev
reviewed
Sep 5, 2024
Colonial-Dev
reviewed
Sep 5, 2024
Colonial-Dev
requested changes
Sep 5, 2024
|
@Colonial-Dev, I have addressed some of your reviews. Please take a look and let me know if it meets your approval now. I have also added an example folder demonstrating how to use it, making it easy to see the results by running |
Colonial-Dev
approved these changes
Sep 9, 2024
Add a 'main' function that prints the generated theme, so the example will compile.
|
Looks good to me!
Yeah, I feel you. The Helix theme support is almost done! |
|
@Colonial-Dev Btw I'm building a project based on this feature https://github.com/guilhermeprokisch/see/ Anything I'm here to help inkjet maintenance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Colonial-Dev,
Here is a draft for implementing the terminal formatter. My Rust skills are not the best, so there might be some bugs in it. I was able to make it work in one of my projects, so it should be at least on the right track. I'm sharing more to ensure that the work is not lost.