N°7963 - Inlineimage::SetDefaultOrgId blend field name between Person and linked class #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rquetiez
requested changes
Nov 25, 2024
|
Code review:
|
|
Code review: |
|
I've added Vincent to the reviewers so that he will check the unit tests |
… and linked class
…erRights::GetOwnerOrganizationAttCode($sClass)
accognet
force-pushed
the
feature/7963-InlineImageSetDefaultOrgId
branch
from
3ff97be to
724d283
Compare
rquetiez
requested changes
Feb 17, 2025
rquetiez
approved these changes
Feb 17, 2025
rquetiez
requested changes
Feb 18, 2025
| @@ -3663,6 +3664,8 @@ public function DBUpdate() | |||
| return $this->m_iKey; | |||
| } | |||
|
|
|||
| $this->UpdateOrganizationOfInlineImages($aChanges); | |||
There was a problem hiding this comment.
The update should be done after the object is persisted. With the current implementation, an update interrupted by a CheckToWrite answering "no" will leave the data in an unconsistent state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal
Allow to use DBObject::MapContextParam without bug