fix: pin Python version to 3.12 to resolve comfy-cli compatibility issue #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workflow was using Python "3.x" which selected Python 3.14. However, comfy-cli has compatibility issues with Python 3.14 due to stricter type annotation handling in the new Python version. This was causing the GitHub Actions job to fail with a traceback in the inspect module. This change pins the Python version to 3.12, which is a stable LTS version that is fully compatible with comfy-cli and all its dependencies. Fixes: https://github.com/Comfy-Org/Comfy-PR/actions/runs/18996324879/job/54256650437 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@copilot resolve conflicts |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Python version specification in the GitHub Actions workflow from a flexible "3.x" pattern to a pinned version "3.12".
- Changed Python version from "3.x" to "3.12" in the comfy-pr workflow
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* fix: pin Python version to 3.13 to resolve comfy-cli compatibility issue (#101) Python 3.14 introduced breaking changes that cause comfy-cli to fail with: NameError: name 'dataclasses' is not defined This change pins the Python version to 3.13 which is compatible with comfy-cli. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <[email protected]> * Initial plan * Resolve merge conflicts and pin Python to 3.12 in all workflows Co-authored-by: snomiao <[email protected]> --------- Co-authored-by: sno <[email protected]> Co-authored-by: Claude <[email protected]> Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: snomiao <[email protected]>
Resolved merge conflicts by accepting Python 3.13 from main branch. The main branch already updated to Python 3.13 in PRs #101 and #102, which is compatible with comfy-cli. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
PR Status Update✅ All CICD checks are passing! What was done:
Changed files:
CICD Results:
Commit: d57ceac 🤖 Generated with Claude Code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
The workflow was using
python-version: "3.x"which automatically selected the latest Python version (3.14). However, comfy-cli has compatibility issues with Python 3.14 due to changes in theinspectmodule's handling of type annotations. This caused the following error:Test Plan
Related
Fixes: https://github.com/Comfy-Org/Comfy-PR/actions/runs/18996324879/job/54256650437
🤖 Generated with Claude Code