Assets Part 2 - add more endpoints#12125
Merged
comfyanonymous merged 45 commits intomasterfrom Jan 31, 2026
Merged
Conversation
…for now, make posting assets endpoint inaccessible with a 501
Kosinkadink
changed the title
…ed @ROUTES.put(f"/api/assets/{{id:{UUID_RE}}}/preview") and @ROUTES.post("/api/assets/scan/seed") and their related schema_in objects
…, add note about blake3 requirement to test out
…ession with statement
…r closing the db session
…o test-assets (blake3 can eventually be removed from there when it becomes a core dependency)
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
* Not sure about this one, but try removing assets from old sessions. * Simplify _prune_orphaned_assets: merge functions, use list comprehensions Amp-Thread-ID: https://ampcode.com/threads/T-019c0917-0dc3-75ab-870d-a32b3fdc1927 Co-authored-by: Amp <amp@ampcode.com> * Refactor _prune_orphaned_assets for readability Amp-Thread-ID: https://ampcode.com/threads/T-019c0917-0dc3-75ab-870d-a32b3fdc1927 Co-authored-by: Amp <amp@ampcode.com> * Add unit tests for pruning * Add unit tests for _prune_orphaned_assets Tests cover: - Orphaned seed assets pruned when file removed - Seed assets with valid files survive - Hashed assets not pruned even without file - Multi-root pruning - SQL LIKE escape handling for %, _, spaces Amp-Thread-ID: https://ampcode.com/threads/T-019c0c7a-5c8a-7548-b6c3-823e9829ce74 Co-authored-by: Amp <amp@ampcode.com> * Ruff fix --------- Co-authored-by: Amp <amp@ampcode.com>
simonri
pushed a commit
to simonri/ComfyUI-flash-attention-3
that referenced
this pull request
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the code for asset-related endpoints that the frontend can start using + enhancing. This API is still under construction, so any custom node developers should not use it yet.
Input/output scanning is not included yet, as the fast scans do take ~1 second when the amount of assets gets to 15k . However, that can be solved with an incremental PR that will make the scans happen on a separate thread that will keep the /object_info (and startup) calls from being delayed.
About ~2400 of the added lines are tests.
Endpoints present now: