fix(billing): DES review polish on workspace billing UI#12917
Merged
Conversation
- Remove the dead 'Upgrade' badge beside Plans & pricing in the account popover (canUpgrade was hardcoded false, so it never rendered) - Match the Subscribe-to-Run button height to its sibling run button (h-8 rounded-lg) - Drop the duplicate outer border/radius on the member 'subscription inactive' dialog: the layout-dialog frame already zeroes content border, but root kept its default border+radius, doubling the card's
dosubot
Bot
added
the
size:S
🎭 Playwright: ✅ 1680 passed, 0 failed📊 Browser Reports
|
🎨 Storybook: ✅ Built — View Storybook |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #12917 +/- ##
===========================================
- Coverage 76.60% 62.13% -14.47%
===========================================
Files 1568 1456 -112
Lines 104249 75060 -29189
Branches 31075 19519 -11556
===========================================
- Hits 79862 46641 -33221
- Misses 23533 28075 +4542
+ Partials 854 344 -510
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1170 files with indirect coverage changes 🚀 New features to boost your workflow:
|
jtydhr88
approved these changes
Jun 17, 2026
dante01yoon
added
cloud/1.46
|
dante01yoon
added
cloud/1.45
|
christian-byrne
pushed a commit
that referenced
this pull request
Jun 27, 2026
…lling UI (#12917) (#13195) Backport of #12917 to `cloud/1.45`. Cherry-picked squash commit `543a39a6b05dd11cc10b1ac3adc2ab28a898dc31`. Original authorship preserved. Applies 2 of the 3 polish items, which are independent of the facade/run-lock stack: - **Remove dead 'Upgrade' badge** in `CurrentUserPopoverWorkspace.vue` - **Subscribe-to-Run button height** (`SubscribeToRun.vue`, `size=unset` + `h-8`) **Deferred (1 item):** the member 'subscription inactive' dialog border polish in `useSubscriptionDialog.ts` targets the `SubscriptionInactiveMemberDialog` block from **FE-978 (#12786)**, which is not yet on `cloud/1.45`. Resolved the conflict by keeping cloud/1.45's version (the block doesn't exist here yet). Re-apply that one-line `root` pt polish (`border-none rounded-none shadow-none`) when #12786's backport lands. Co-authored-by: GitHub Action <action@github.com>
Member
|
@dante01yoon Successfully backported to #13319 |
github-actions
Bot
removed
the
needs-backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before
https://www.figma.com/board/R9eN9DHmDgX3qEJXsRKiRr?node-id=410-297#1803836299
after
Design-review polish on the team-workspace billing UI (3 of the items from the Figma 'Team Plan - Workspaces' review). All three components are on main.
1. Remove dead 'Upgrade' badge in account popover
CurrentUserPopoverWorkspace.vue— the white badge beside 'Plans & pricing' was gated oncanUpgrade, which is hardcodedfalse(PRO is the only tier), so it never rendered. Removed the badge markup and the dead computed. (Figma node 2797-724189.)2. Subscribe-to-Run button height
SubscribeToRun.vue— usedsize="sm", which didn't match the sibling run/queue button (anh-8button group it swaps with in the same slot viaCloudRunButtonWrapper). Switched tosize="unset"+h-8 rounded-lg gap-1.5 px-4to match.3. Duplicate border/radius on member 'subscription inactive' dialog
useSubscriptionDialog.ts— the layout dialog already zeroes the content border (border-none shadow-none), but the root pt kept onlybg-transparent, so the dialog frame's default border+radius doubled with the card's ownrounded-2xl border. Addedborder-none rounded-none shadow-noneto root so only the card's single border/radius shows. (Figma node 3253-19473.)Surfaced during Billing V1 design review (team workspaces).