refactor: remove unused OAuthConsentDecision type#13277
Draft
DrJKL wants to merge 1 commit into
Draft
Conversation
The OAuthConsentDecision type alias had no references anywhere (the function submitOAuthConsentDecision is not annotated with it, and nothing imports it). Removed. The other type/enum candidates fallow flagged were verified as NOT dead and are left untouched: - NodeBadgeMode.None/ShowAll/HideBuiltIn: consumed via Object.values across coreSettings, apiSchema (zod enum), and the badge composables. - src/types/index.ts barrel and litegraph types: public/extension surface. - generatedManagerTypes paths/webhooks/$defs/operations: openapi-codegen output, not hand-editable.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 1693 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-06-29T06:56:32.821Z",
"gitSha": "9ab90c29f90e742981acc168f36205091a872ff6",
"branch": "drjkl/cleanup-dead-types",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2108.5230000001047,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.987999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.025,
"heapDeltaBytes": 11394356,
"heapUsedBytes": 64119220,
"domNodes": -283,
"jsHeapTotalBytes": 14843904,
"scriptDurationMs": 19.632,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2011.5470000000641,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.102999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 345.697,
"heapDeltaBytes": -2239744,
"heapUsedBytes": 56557868,
"domNodes": 14,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 14.009,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1774.7059999999237,
"styleRecalcs": 73,
"styleRecalcDurationMs": 32.153,
"layouts": 12,
"layoutDurationMs": 3.4219999999999997,
"taskDurationMs": 714.7320000000001,
"heapDeltaBytes": -6952728,
"heapUsedBytes": 51705876,
"domNodes": 54,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 108.11800000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1743.16500000009,
"styleRecalcs": 73,
"styleRecalcDurationMs": 31.878999999999998,
"layouts": 12,
"layoutDurationMs": 3.4209999999999994,
"taskDurationMs": 702.659,
"heapDeltaBytes": -7030548,
"heapUsedBytes": 51916936,
"domNodes": 55,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 107.88499999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1745.9919999998874,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.217000000000002,
"layouts": 6,
"layoutDurationMs": 0.632,
"taskDurationMs": 277.333,
"heapDeltaBytes": 1476932,
"heapUsedBytes": 53538080,
"domNodes": 76,
"jsHeapTotalBytes": 14417920,
"scriptDurationMs": 17.002999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.1589999998196,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.693999999999999,
"layouts": 6,
"layoutDurationMs": 0.6659999999999999,
"taskDurationMs": 295.598,
"heapDeltaBytes": 1908968,
"heapUsedBytes": 60641356,
"domNodes": 76,
"jsHeapTotalBytes": 26738688,
"scriptDurationMs": 18.368,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 547.6280000000315,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.506,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 316.525,
"heapDeltaBytes": 7168628,
"heapUsedBytes": 65967392,
"domNodes": 14,
"jsHeapTotalBytes": 17563648,
"scriptDurationMs": 53.57299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 559.1660000000047,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.356000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 318.17699999999996,
"heapDeltaBytes": 6997448,
"heapUsedBytes": 65913132,
"domNodes": 20,
"jsHeapTotalBytes": 18874368,
"scriptDurationMs": 52.196999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2017.3050000000785,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.584,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.11499999999995,
"heapDeltaBytes": -9585296,
"heapUsedBytes": 61936164,
"domNodes": 24,
"jsHeapTotalBytes": 9842688,
"scriptDurationMs": 75.98,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2009.4560000000001,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.677999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.707,
"heapDeltaBytes": -10163424,
"heapUsedBytes": 61335820,
"domNodes": 20,
"jsHeapTotalBytes": 10104832,
"scriptDurationMs": 76.285,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2089.3220000000383,
"styleRecalcs": 70,
"styleRecalcDurationMs": 20.904,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 967.5279999999999,
"heapDeltaBytes": 10704064,
"heapUsedBytes": 83529184,
"domNodes": 20,
"jsHeapTotalBytes": 10018816,
"scriptDurationMs": 351.209,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2096.86499999998,
"styleRecalcs": 69,
"styleRecalcDurationMs": 20.715000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 989.8770000000001,
"heapDeltaBytes": 10284564,
"heapUsedBytes": 83356960,
"domNodes": 20,
"jsHeapTotalBytes": 11591680,
"scriptDurationMs": 358.864,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3087.256000000025,
"styleRecalcs": 66,
"styleRecalcDurationMs": 20.020000000000003,
"layouts": 60,
"layoutDurationMs": 7.998999999999999,
"taskDurationMs": 1210.652,
"heapDeltaBytes": 13767284,
"heapUsedBytes": 68837368,
"domNodes": 14,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 458.686,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3119.318000000021,
"styleRecalcs": 67,
"styleRecalcDurationMs": 21.112000000000002,
"layouts": 60,
"layoutDurationMs": 8.275999999999998,
"taskDurationMs": 1268.217,
"heapDeltaBytes": 13829156,
"heapUsedBytes": 68890848,
"domNodes": 16,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 474.12799999999993,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2011.89700000009,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.034999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.089,
"heapDeltaBytes": 10463668,
"heapUsedBytes": 71335768,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 73.60900000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2022.26799999994,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.716000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.11699999999996,
"heapDeltaBytes": -9329648,
"heapUsedBytes": 64133340,
"domNodes": 18,
"jsHeapTotalBytes": 8269824,
"scriptDurationMs": 78.834,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 554.8840000001292,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.237000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.51699999999994,
"heapDeltaBytes": -12496076,
"heapUsedBytes": 55979392,
"domNodes": 20,
"jsHeapTotalBytes": 21270528,
"scriptDurationMs": 116.01199999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 549.7700000000805,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.265,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 354.943,
"heapDeltaBytes": 7606776,
"heapUsedBytes": 66450432,
"domNodes": 20,
"jsHeapTotalBytes": 19922944,
"scriptDurationMs": 119.06400000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1990.6220000000303,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.702000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 334.82700000000006,
"heapDeltaBytes": -2242520,
"heapUsedBytes": 56571556,
"domNodes": 20,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 12.236,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1990.1079999999638,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.740999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 338.87100000000004,
"heapDeltaBytes": -1915828,
"heapUsedBytes": 57137216,
"domNodes": 18,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 13.288000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.1219999998266,
"styleRecalcs": 76,
"styleRecalcDurationMs": 33.375,
"layouts": 16,
"layoutDurationMs": 3.9050000000000002,
"taskDurationMs": 609.105,
"heapDeltaBytes": -10593672,
"heapUsedBytes": 48204076,
"domNodes": 62,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 81.002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1671.1639999998624,
"styleRecalcs": 76,
"styleRecalcDurationMs": 30.971000000000007,
"layouts": 16,
"layoutDurationMs": 3.763,
"taskDurationMs": 606.9749999999999,
"heapDeltaBytes": -10459728,
"heapUsedBytes": 48315696,
"domNodes": 64,
"jsHeapTotalBytes": 26738688,
"scriptDurationMs": 79.61599999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 932.5840000001335,
"styleRecalcs": 18,
"styleRecalcDurationMs": 27.244999999999997,
"layouts": 5,
"layoutDurationMs": 12.277999999999997,
"taskDurationMs": 711.821,
"heapDeltaBytes": 4512268,
"heapUsedBytes": 80934592,
"domNodes": 13833,
"jsHeapTotalBytes": 17563648,
"scriptDurationMs": 24.983000000000004,
"eventListeners": 2531,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8111.893000000009,
"styleRecalcs": 250,
"styleRecalcDurationMs": 57.306999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3369.0580000000004,
"heapDeltaBytes": -3916836,
"heapUsedBytes": 68111364,
"domNodes": 20,
"jsHeapTotalBytes": 16572416,
"scriptDurationMs": 1114.408,
"eventListeners": 20,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8138.851999999815,
"styleRecalcs": 251,
"styleRecalcDurationMs": 59.501000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3739.923,
"heapDeltaBytes": 4319428,
"heapUsedBytes": 76248060,
"domNodes": 20,
"jsHeapTotalBytes": 22339584,
"scriptDurationMs": 1304.1009999999999,
"eventListeners": 20,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12995.601000000079,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12977.462,
"heapDeltaBytes": -16445368,
"heapUsedBytes": 182176000,
"domNodes": -3305,
"jsHeapTotalBytes": 21204992,
"scriptDurationMs": 489.074,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13610.610999999835,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13593.197,
"heapDeltaBytes": -36728216,
"heapUsedBytes": 169754784,
"domNodes": -3304,
"jsHeapTotalBytes": 20418560,
"scriptDurationMs": 500.6090000000001,
"eventListeners": -16374,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15388.06899999986,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.831999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15365.668000000001,
"heapDeltaBytes": -5001464,
"heapUsedBytes": 178214548,
"domNodes": -3303,
"jsHeapTotalBytes": 17186816,
"scriptDurationMs": 746.105,
"eventListeners": -16383,
"totalBlockingTimeMs": 34,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 15290.015999999923,
"styleRecalcs": 75,
"styleRecalcDurationMs": 19.497000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15268.365000000003,
"heapDeltaBytes": -8329336,
"heapUsedBytes": 183621900,
"domNodes": -3302,
"jsHeapTotalBytes": 21118976,
"scriptDurationMs": 761.895,
"eventListeners": -16370,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.216666666666665,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 437.27400000011585,
"styleRecalcs": 17,
"styleRecalcDurationMs": 21.380000000000003,
"layouts": 5,
"layoutDurationMs": 1.385,
"taskDurationMs": 107.52499999999999,
"heapDeltaBytes": 5364332,
"heapUsedBytes": 65229304,
"domNodes": 170,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 15.973,
"eventListeners": 69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 453.49400000009155,
"styleRecalcs": 16,
"styleRecalcDurationMs": 22.221,
"layouts": 4,
"layoutDurationMs": 1.181,
"taskDurationMs": 115.78,
"heapDeltaBytes": 5149616,
"heapUsedBytes": 65031888,
"domNodes": 155,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 20.614999999999995,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## drjkl/cleanup-dead-exports #13277 +/- ##
============================================================
Coverage 78.24% 78.24%
============================================================
Files 1633 1633
Lines 114080 114080
Branches 38352 38989 +637
============================================================
Hits 89257 89257
Misses 23918 23918
Partials 905 905
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
OAuthConsentDecisiontype alias had no references anywhere — the functionsubmitOAuthConsentDecisionis not annotated with it, and nothing imports it. Removed.The other type/enum candidates fallow flagged were verified as NOT dead and left untouched:
NodeBadgeMode.None/ShowAll/HideBuiltIn— consumed viaObject.valuesacrosscoreSettings,apiSchema(zod enum), and the badge composables.src/types/index.tsbarrel and litegraph types — public/extension surface.generatedManagerTypespaths/webhooks/$defs/operations— openapi-codegen output, not hand-editable.Gates: typecheck, knip pass (type-only change).
Stacked PR. Base:
drjkl/cleanup-dead-exports.