[candidate fix] flip dialog default renderer to Reka on cloud/1.45 (non-billing)#13307
Closed
christian-byrne wants to merge 2 commits into
Closed
[candidate fix] flip dialog default renderer to Reka on cloud/1.45 (non-billing)#13307christian-byrne wants to merge 2 commits into
christian-byrne wants to merge 2 commits into
Conversation
…e 6a cutover, stacked on #12848. 6a-2) (#12593) The **renderer cutover** for Phase 6: every remaining dialog caller is flipped to Reka, and `createDialog` now defaults `renderer: 'reka'` so the PrimeVue `Dialog` branch is no longer reached by default (it survives only as an explicit `renderer: 'primevue'` escape hatch, deleted in Phase 6b). > **Stacked on #12848** (mask editor + 3D viewer dialogs + dialog infra). Per @jtydhr88's review, the heavy, screenshot-bearing surface (3D + mask editor) was split into #12848 so it reviews and tests on its own. **Merge #12848 first**, then this PR's base auto-retargets to `main`. Parent: [FE-571](https://linear.app/comfyorg/issue/FE-571/dialog-system-migration-primevue-reka-ui-parent) This phase: [FE-578](https://linear.app/comfyorg/issue/FE-578/phase-6-remove-primevue-dialogconfirmdialog-imports-clean-up-css) - **drop dead `ConfirmationService` registration** — zero `useConfirm`/`<ConfirmDialog>` consumers remain in `src/`; desktop-ui keeps its own. - **flip `showConfirmDialog`** — all six confirm callers render Reka chrome; width goes from PrimeVue auto-hug to fixed `size:'md'`, matching `dialogService.confirm()`. - **flip remaining `dialogService` + composable callers** — signin, update-password, top-up, workspace family, cancel-subscription, publish, cloud-notification, edit-keybinding / node-conflict / import-failed, upload-model, queue-clear-history, delete-assets, share / open-shared-workflow, subscription pricing. Self-styled panels get a shared transparent `w-fit` chrome replicating PrimeVue's auto-sized root. - **default `createDialog` to `renderer:'reka'`** — cuts over `showExtensionDialog` (third-party dialogs) and anything unflagged. The single-commit revert point. - **retarget class-based e2e selectors** — `BaseDialog` `.p-dialog` → `getByRole('dialog')`, `BuilderSaveAsHelper` close-X → `getByLabel`, `shareWorkflowDialog` role-based, dead `confirm-dialog` testid removed. - honor `[autofocus]` inside Reka dialogs; size the template browser dialog so the filter bar fits; drop redundant Tailwind width constraints on the remaining callers. 1. **`modal:false` on the pricing dialogs** — same trade-off as Settings/Manager (visual overlay without focus trap) because `PricingTable(.Workspace)` hosts a body-teleported PrimeVue `Popover`. 2. **`w-fit` shrink-wrapped chrome** for self-styled panels — replicates PrimeVue's shrink-to-fit root. 3. **Confirm width change** (auto-hug → fixed 576px `md`) — intentional consistency with `dialogService.confirm()`. `createDialog` now defaults to Reka. Third-party extension dialogs render through Reka by default — a fixed `size:'md'` frame with a modal focus trap instead of PrimeVue auto-width; `renderer:'primevue'` remains an explicit escape hatch until Phase 6b. Worth a release note for extension authors. PrimeVue branch deletion (`GlobalDialog.vue` legacy branch, `PrimeDialog` import, `.p-dialog` CSS/bridge tokens, `dialogStore` `pt`/`position`/`unstyled` typing) — lands after this soaks one cloud deploy cycle. Captured via Chrome DevTools (CDP) from this branch running locally in **cloud mode** (proxied to the `cloud.comfy.org` backend, free Personal Workspace). Every dialog below now renders through the **Reka** path — the PrimeVue `Dialog` branch is no longer reached. (Mask editor + 3D viewers live in the stacked base #12848.) **Confirm dialog** (`showConfirmDialog`) — Reka chrome at a fixed `size:'md'`, replacing PrimeVue's auto-hug width — *review focus #3* <img width="880" alt="confirm-dialog" src="https://github.com/user-attachments/assets/5d9953c1-4d0c-4ff9-adc7-88dd370c6a24" /> **Settings** — renders through Reka <img width="880" alt="settings" src="https://github.com/user-attachments/assets/44e3fd3f-8d9b-4322-8fbe-8ce8d94ed15d" /> **Edit Keybinding**, stacked on Settings — small-layout `w-fit` chrome; closing it leaves Settings open (stacked-dismiss holds) <img width="880" alt="edit-keybinding-nested" src="https://github.com/user-attachments/assets/d0875c00-7b9c-439d-b24d-ba6770009d08" /> **Subscription pricing** (`PricingTable`) — opened with `modal:false` because it hosts a body-teleported PrimeVue `Popover` — *review focus <img width="880" alt="subscription-pricing" src="https://github.com/user-attachments/assets/3be20397-8a69-4b00-b803-73eff4e0e313" /> **Share** and **Publish** (open-shared-workflow + publish) — shared transparent shrink-wrapped (`w-fit`) chrome — *review focus #2* <img width="880" alt="share-dialog" src="https://github.com/user-attachments/assets/16f1c1b5-e35e-4664-a957-2f7f61ad96bd" /> <img width="880" alt="publish-dialog" src="https://github.com/user-attachments/assets/935ff453-5247-430f-9c21-2f500d4bc6e2" /> **Workspace** (workspace-family callers) <img width="880" alt="workspace-settings" src="https://github.com/user-attachments/assets/8031a352-f6fc-41e4-9567-e26e0c35ecd9" /> **Template selector** (`showExtensionDialog` / `useWorkflowTemplateSelectorDialog`) <img width="880" alt="templates-dialog" src="https://github.com/user-attachments/assets/9975ebbe-75ae-4ad9-a90a-248db4850e1a" /> **Account / workspace menu** (cloud) <img width="880" alt="account-menu" src="https://github.com/user-attachments/assets/5bc0cade-9bd9-49de-8bb4-779d65e211b0" />
… cutover) Backports #12593's createDialog default-renderer flip + e2e fixture/selector migrations to cloud/1.45. cloud/1.45 still defaulted dialogs to the PrimeVue renderer, whose mask enter-transition is flaky under cloud's heavier init — hanging the builderSaveFlow / memberRoleChange / keybindingPresets confirm e2e. main defaults to Reka (no PrimeVue mask), which is why those specs pass there. Release-line adaptations vs #12593: - keep cloud/1.45's billing dialogs (useSubscriptionDialog/useModelUpload/ dialogService) as-is — they already set renderer:'reka' explicitly and have diverged from main; out of scope for this e2e fix. - keep ConfirmationService registered — SecretsPanel still uses PrimeVue useConfirm() on cloud/1.45 (main had migrated all consumers). - drop confirmDialog's headerClass/bodyClass/footerClass — not on cloud/1.45's DialogComponentProps type yet. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-06-30T03:42:15.837Z",
"gitSha": "42ec342a8cbe791e0bd241842ed10af838b6d182",
"branch": "fix/cloud-1.45-dialog-reka-cutover",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2038.5760000000062,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.326999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 336.72999999999996,
"heapDeltaBytes": -2433948,
"heapUsedBytes": 56138256,
"domNodes": 18,
"jsHeapTotalBytes": 26476544,
"scriptDurationMs": 17.398000000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1991.3819999999305,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.872,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 295.14300000000003,
"heapDeltaBytes": -2469152,
"heapUsedBytes": 55604904,
"domNodes": 22,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 17.241,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1688.2109999999955,
"styleRecalcs": 72,
"styleRecalcDurationMs": 27.97,
"layouts": 12,
"layoutDurationMs": 2.6650000000000005,
"taskDurationMs": 609.813,
"heapDeltaBytes": -7174640,
"heapUsedBytes": 51357404,
"domNodes": 55,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 95.159,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1695.920000000001,
"styleRecalcs": 71,
"styleRecalcDurationMs": 28.204,
"layouts": 12,
"layoutDurationMs": 3.0509999999999993,
"taskDurationMs": 611.196,
"heapDeltaBytes": 14854232,
"heapUsedBytes": 59596348,
"domNodes": -251,
"jsHeapTotalBytes": 17301504,
"scriptDurationMs": 93.68799999999999,
"eventListeners": -167,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.0399999999981,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.599,
"layouts": 6,
"layoutDurationMs": 0.576,
"taskDurationMs": 327.644,
"heapDeltaBytes": 5772040,
"heapUsedBytes": 74266612,
"domNodes": -226,
"jsHeapTotalBytes": 17760256,
"scriptDurationMs": 22.018,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1719.94200000006,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.216,
"layouts": 6,
"layoutDurationMs": 0.521,
"taskDurationMs": 288.018,
"heapDeltaBytes": -3790524,
"heapUsedBytes": 65057212,
"domNodes": -226,
"jsHeapTotalBytes": 12517376,
"scriptDurationMs": 14.990000000000002,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 539.6119999999769,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.267,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.84299999999996,
"heapDeltaBytes": -21905108,
"heapUsedBytes": 47071012,
"domNodes": -277,
"jsHeapTotalBytes": 6225920,
"scriptDurationMs": 56.393,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 480.30000000005657,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.589999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 326.49899999999997,
"heapDeltaBytes": 4008256,
"heapUsedBytes": 72504444,
"domNodes": -297,
"jsHeapTotalBytes": 6225920,
"scriptDurationMs": 47.760999999999996,
"eventListeners": -189,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2003.1809999999837,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.368,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.152,
"heapDeltaBytes": -9824160,
"heapUsedBytes": 59117436,
"domNodes": 24,
"jsHeapTotalBytes": 12201984,
"scriptDurationMs": 75.19099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2007.0269999999937,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.296,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.232,
"heapDeltaBytes": -9121228,
"heapUsedBytes": 59787264,
"domNodes": 22,
"jsHeapTotalBytes": 11939840,
"scriptDurationMs": 81.486,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2045.6679999999778,
"styleRecalcs": 67,
"styleRecalcDurationMs": 15.329,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 810.216,
"heapDeltaBytes": 29438088,
"heapUsedBytes": 82932968,
"domNodes": -276,
"jsHeapTotalBytes": 1253376,
"scriptDurationMs": 298.33799999999997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2042.5780000000486,
"styleRecalcs": 68,
"styleRecalcDurationMs": 16.342000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 803.2669999999999,
"heapDeltaBytes": 9956924,
"heapUsedBytes": 81485836,
"domNodes": 18,
"jsHeapTotalBytes": 12115968,
"scriptDurationMs": 297.063,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3103.885000000048,
"styleRecalcs": 65,
"styleRecalcDurationMs": 16.246,
"layouts": 60,
"layoutDurationMs": 6.940000000000001,
"taskDurationMs": 1089.113,
"heapDeltaBytes": 55034116,
"heapUsedBytes": 111340472,
"domNodes": 12,
"jsHeapTotalBytes": 47710208,
"scriptDurationMs": 386.636,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3050.2179999999726,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.763000000000002,
"layouts": 60,
"layoutDurationMs": 6.872999999999999,
"taskDurationMs": 1000.229,
"heapDeltaBytes": 11407316,
"heapUsedBytes": 66848140,
"domNodes": 10,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 380.938,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 1992.6340000000096,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.343000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.3,
"heapDeltaBytes": 31490772,
"heapUsedBytes": 86062540,
"domNodes": -266,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 67.63199999999999,
"eventListeners": -191,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2014.6389999999883,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.399000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.26400000000007,
"heapDeltaBytes": 50568700,
"heapUsedBytes": 116590076,
"domNodes": -266,
"jsHeapTotalBytes": 31232000,
"scriptDurationMs": 67.329,
"eventListeners": -193,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 488.10500000001866,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.697000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 341.023,
"heapDeltaBytes": 4470868,
"heapUsedBytes": 73383976,
"domNodes": -275,
"jsHeapTotalBytes": 7012352,
"scriptDurationMs": 94.94000000000001,
"eventListeners": -193,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 505.49999999998363,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.979999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 346.615,
"heapDeltaBytes": -2300576,
"heapUsedBytes": 50600332,
"domNodes": -267,
"jsHeapTotalBytes": -1376256,
"scriptDurationMs": 102.69500000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2021.0889999999893,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.659999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.875,
"heapDeltaBytes": 17515544,
"heapUsedBytes": 86422600,
"domNodes": -299,
"jsHeapTotalBytes": 38731776,
"scriptDurationMs": 13.927999999999999,
"eventListeners": -195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000007,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 1992.578000000094,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.216,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 288.767,
"heapDeltaBytes": 2310280,
"heapUsedBytes": 65766008,
"domNodes": 22,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 14.269,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.6419999999828,
"styleRecalcs": 75,
"styleRecalcDurationMs": 31.197999999999997,
"layouts": 16,
"layoutDurationMs": 3.882,
"taskDurationMs": 557.129,
"heapDeltaBytes": 18726868,
"heapUsedBytes": 75613320,
"domNodes": 61,
"jsHeapTotalBytes": 18874368,
"scriptDurationMs": 83.881,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.3200000000616,
"styleRecalcs": 75,
"styleRecalcDurationMs": 28.519999999999996,
"layouts": 16,
"layoutDurationMs": 3.284,
"taskDurationMs": 540.714,
"heapDeltaBytes": -11248188,
"heapUsedBytes": 52444104,
"domNodes": 63,
"jsHeapTotalBytes": 23138304,
"scriptDurationMs": 73.022,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 816.1380000000236,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.592000000000002,
"layouts": 7,
"layoutDurationMs": 10.069,
"taskDurationMs": 559.2579999999999,
"heapDeltaBytes": 2381424,
"heapUsedBytes": 77157004,
"domNodes": 13513,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 19.791000000000004,
"eventListeners": 2527,
"totalBlockingTimeMs": 99,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8104.717000000051,
"styleRecalcs": 250,
"styleRecalcDurationMs": 51.352000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3016.9260000000004,
"heapDeltaBytes": 9224020,
"heapUsedBytes": 74171152,
"domNodes": -260,
"jsHeapTotalBytes": 11071488,
"scriptDurationMs": 964.617,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8079.41500000004,
"styleRecalcs": 250,
"styleRecalcDurationMs": 50.395,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2896.919,
"heapDeltaBytes": -3115340,
"heapUsedBytes": 65939352,
"domNodes": 22,
"jsHeapTotalBytes": 18669568,
"scriptDurationMs": 969.465,
"eventListeners": 22,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13463.426000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13451.371000000001,
"heapDeltaBytes": 154661836,
"heapUsedBytes": 371817428,
"domNodes": -3306,
"jsHeapTotalBytes": 139722752,
"scriptDurationMs": 596.29,
"eventListeners": -16468,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11279.797000000031,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11270.516000000001,
"heapDeltaBytes": -23169936,
"heapUsedBytes": 179533932,
"domNodes": -3337,
"jsHeapTotalBytes": 20942848,
"scriptDurationMs": 462.918,
"eventListeners": -16472,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 12304.306999999993,
"styleRecalcs": 64,
"styleRecalcDurationMs": 17.087999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12288.634,
"heapDeltaBytes": -28203584,
"heapUsedBytes": 184690736,
"domNodes": -3306,
"jsHeapTotalBytes": 23740416,
"scriptDurationMs": 740.214,
"eventListeners": -16474,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 15310.858999999937,
"styleRecalcs": 73,
"styleRecalcDurationMs": 19.062999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15293.538000000002,
"heapDeltaBytes": 144076060,
"heapUsedBytes": 389210576,
"domNodes": -3302,
"jsHeapTotalBytes": 152305664,
"scriptDurationMs": 814.068,
"eventListeners": -16470,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 446.474999999964,
"styleRecalcs": 18,
"styleRecalcDurationMs": 20.988,
"layouts": 5,
"layoutDurationMs": 1.1469999999999998,
"taskDurationMs": 181.14200000000002,
"heapDeltaBytes": -21387540,
"heapUsedBytes": 48188044,
"domNodes": -155,
"jsHeapTotalBytes": 4653056,
"scriptDurationMs": 18.194,
"eventListeners": -105,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 452.36499999987245,
"styleRecalcs": 17,
"styleRecalcDurationMs": 23.298,
"layouts": 5,
"layoutDurationMs": 1.0899999999999999,
"taskDurationMs": 181.446,
"heapDeltaBytes": -22002492,
"heapUsedBytes": 47990468,
"domNodes": -188,
"jsHeapTotalBytes": 4915200,
"scriptDurationMs": 18.748,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
🎭 Playwright: ❌ 1553 passed, 50 failed · 1 flaky❌ Failed Tests📊 Browser Reports
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft candidate for the staging e2e failures. Backports #12593's default-renderer flip + e2e fixtures, excluding the billing dialog callers (kept cloud/1.45's divergent versions) and keeping ConfirmationService (SecretsPanel still uses PrimeVue useConfirm). Running CI to verify the 3 failing specs go green without billing regressions. Sibling experiment #13306 tests the default-flip alone.