Skip to content

Implement Context Keys & Conditional Keybinds #3676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Implement Context Keys & Conditional Keybinds #3676

wants to merge 13 commits into from

Conversation

benceruleanlu
Copy link
Collaborator

@benceruleanlu benceruleanlu commented Apr 28, 2025 •
edited
Loading

Todo

  • Allow assigning a single keycombo to multiple keybinds
  • Unify copy paste functionality into context key system
  • Implement regex match operator and 'in/not in' operators
  • Figure out how to handle extension authors possibly stomping context keys

Future

  • Document available condition keys
  • Allow user to edit the condition
  • Show condition in keybinding panel

Closes #1595 and #1089

┆Issue is synchronized with this Notion page by Unito

@benceruleanlu benceruleanlu marked this pull request as ready for review April 28, 2025 21:40
@benceruleanlu benceruleanlu requested review from a team as code owners April 28, 2025 21:40
huchenlei
huchenlei requested changes Apr 29, 2025
View reviewed changes
@benceruleanlu benceruleanlu marked this pull request as draft April 29, 2025 20:09
@benceruleanlu benceruleanlu changed the title Conditional Keybinds Proposal Implement conditional keybinds Apr 29, 2025
@benceruleanlu benceruleanlu changed the title Implement conditional keybinds Implement Context Keys & Conditional Keybinds Apr 30, 2025
@benceruleanlu benceruleanlu force-pushed the conditional-keybinds branch from 7e4867c to a77c954 Compare May 2, 2025 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huchenlei huchenlei huchenlei requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: temporarily disable hotkeys or context based hotkeys
2 participants
@benceruleanlu @huchenlei