feat(ComboWidget): add ability to have mapped inputs #6585
+1,801
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/05/2025, 04:02:01 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results⏰ Completed at: 11/05/2025, 04:19:16 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.24 MB (baseline 3.31 MB) • 🟢 -63.1 kBMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 791 kB (baseline 729 kB) • 🔴 +62.4 kBGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 8.18 kB (baseline 8.18 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 293 kB (baseline 293 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 12.6 kB (baseline 12.6 kB) • ⚪ 0 BReusable component library chunks
Status: 1 added / 1 removed Data & Services — 10.4 kB (baseline 10.4 kB) • 🟢 -1 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 1.07 kB (baseline 1.07 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Vendor & Third-Party — 5.32 MB (baseline 5.32 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Status: 3 added / 3 removed Other — 2.55 MB (baseline 2.55 MB) • ⚪ 0 BBundles that do not match a named category
|
arjansingh
force-pushed
the
feat/input-mapping
branch
2 times, most recently
from
8c04ed9 to
c440f6e
Compare
arjansingh
changed the title
arjansingh
force-pushed
the
feat/input-mapping
branch
from
c440f6e to
714e3e9
Compare
arjansingh
commented
Nov 5, 2025
| for (const value of values_list) { | ||
| try { | ||
| const label = this.options.getOptionLabel(String(value)) | ||
| menu.addItem(label, value, menuOptions) |
There was a problem hiding this comment.
Note: one of the downsides of this approach is we don't get the fuzzy search filter because that requires setting the array directly.
Talked it over with @AustinMroz and we do think this is the easiest way to map duplicate labels to the correct value
arjansingh
force-pushed
the
feat/input-mapping
branch
from
714e3e9 to
305b8f8
Compare
arjansingh
commented
Nov 5, 2025
| { | ||
| limit = DEFAULT_LIMIT, | ||
| offset = 0 | ||
| }: { limit?: number; offset?: number } = {} |
There was a problem hiding this comment.
We're not using pagination yet but, at least we're setup to start doing it.
There was a problem hiding this comment.
i know yagni... but i think sooner is sooner than we think 😂
if you really want it removed, i can remove it.
dosubot
bot
added
the
size:XXL
arjansingh
commented
Nov 5, 2025
| async function fetchInputFilesFromCloud(): Promise<AssetItem[]> { | ||
| return await assetService.getAssetsByTag('input', false) | ||
| return await assetService.getAssetsByTag('input', false, { | ||
| limit: INPUT_LIMIT |
There was a problem hiding this comment.
@viva-jinyi I don't think reducing the limit from 500 to 100 should impact your Assets work, but let me know if it does and we can adjust.
DrJKL
reviewed
Nov 5, 2025
Comment on lines
+39
to
+50
| const NODE_MEDIA_TYPE_MAP: Record<string, 'image' | 'video' | 'audio'> = { | ||
| LoadImage: 'image', | ||
| LoadVideo: 'video', | ||
| LoadAudio: 'audio' | ||
| } | ||
|
|
||
| // Map node types to placeholder i18n keys | ||
| const NODE_PLACEHOLDER_MAP: Record<string, string> = { | ||
| LoadImage: 'widgets.uploadSelect.placeholderImage', | ||
| LoadVideo: 'widgets.uploadSelect.placeholderVideo', | ||
| LoadAudio: 'widgets.uploadSelect.placeholderAudio' | ||
| } |
There was a problem hiding this comment.
Option:
Suggested change
| const NODE_MEDIA_TYPE_MAP: Record<string, 'image' | 'video' | 'audio'> = { | |
| LoadImage: 'image', | |
| LoadVideo: 'video', | |
| LoadAudio: 'audio' | |
| } | |
| // Map node types to placeholder i18n keys | |
| const NODE_PLACEHOLDER_MAP: Record<string, string> = { | |
| LoadImage: 'widgets.uploadSelect.placeholderImage', | |
| LoadVideo: 'widgets.uploadSelect.placeholderVideo', | |
| LoadAudio: 'widgets.uploadSelect.placeholderAudio' | |
| } | |
| const NODE_MEDIA_TYPE_MAP = { | |
| LoadImage: 'image', | |
| LoadVideo: 'video', | |
| LoadAudio: 'audio' | |
| } as const | |
| // Map node types to placeholder i18n keys | |
| const NODE_PLACEHOLDER_MAP = { | |
| LoadImage: 'widgets.uploadSelect.placeholderImage', | |
| LoadVideo: 'widgets.uploadSelect.placeholderVideo', | |
| LoadAudio: 'widgets.uploadSelect.placeholderAudio' | |
| } as const |
There was a problem hiding this comment.
I will try this again but it cause some typecheck failure fun for me when i did it locally
DrJKL
approved these changes
Nov 5, 2025
| ] | ||
|
|
||
| const unknownHash = | ||
| 'fffffffffffffffffffffffffffuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuu.png' |
christian-byrne
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
getOptionLabeloption toComboWidgetso users of it can map of custom labels to widget values. (e.g.,"My Photo" -> "my_photo_1235.png").Review Focus
Widget code: please double check the work there.
Screenshots (if applicable)
mapped-inputs-2025-11-04.mov
┆Issue is synchronized with this Notion page by Unito