feat: implement light/dark mode theme switching #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Add ThemeProvider with system preference detection - Create ThemeSwitcher component with sun/moon icons - Update header styling to support theme switching - Configure Tailwind CSS for dark mode support - Refactor theme configurations for reusability - Update global styles for proper theme transitions 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
snomiao
force-pushed
the
sno-light-mode
branch
from
8eb64de to
6efb8da
Compare
This commit includes all changes for the light/dark mode feature: - Updated theme configuration and switcher component - Modified header components to support theme switching - Updated all admin pages and node detail pages with theme support - Added unified breadcrumb component - Removed obsolete storybook stories - Fixed Chinese translation for "Light" mode (轻量级 -> 浅色) - Fixed linting errors in preempted-comfy-node-names and node-version-compatibility 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…to sno-light-mode
Resolved conflicts by: - Keeping light/dark mode implementation from sno-light-mode branch - Accepting updated translations from main branch (includes new "Contribute" keys) - Removed obsolete RegistryStory.tsx file - Fixed linting errors in admin pages The merge brings in translation improvements and new features from main while preserving all light/dark mode theme switching functionality. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Remove problematic CustomThemeBreadcrumb theme prop from UnifiedBreadcrumb - Add named export for UnifiedBreadcrumb component - Fix onClick event handler type to accept React.MouseEvent - Update all admin pages to remove invalid router parameter from breadcrumb helper functions - Fix useSearchParameter calls to return string instead of undefined - Fix CreatePublisherModal prop name from openModal to open 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Includes changes from: - #222: Restructure Storybook for better organization - #226: Add GitHub Actions workflow to update PR branches 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Resolved formatting conflicts in .storybook/main.ts and preview.tsx - Combined theme globalTypes (Dark/Light/System) with locale globalTypes - Merged locale files: kept theme translations (Auto, Dark, Light) and added "All Nodes" from main - Resolved whitespace conflicts in README.md and docs/update-pr-branches.md - Confirmed deletion of NodeList.stories.tsx and Registry.stories.tsx 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Resolved merge conflicts while preserving light mode functionality: ## Key Resolutions: - **Theme Configuration**: Preserved themeConfig.tsx with comprehensive light/dark mode support - **Component Styling**: Maintained dynamic theming classes throughout all components - **Tailwind Config**: Kept darkMode: 'class' configuration for proper theme switching - **Global Styles**: Preserved light/dark mode body styles - **Theme Provider**: Maintained ThemeProvider wrapper in _app.tsx - **Storybook**: Kept enhanced theme configuration and removed obsolete story files - **Locale Files**: Preserved light mode branch translations including theme-related keys - **Pages**: Maintained consistent theming across all admin and node pages ## Changes from Main: - Added new Storybook stories and publisher form components from main - Updated .prettierrc configuration - Integrated latest translations while preserving light mode specific keys The merge maintains full light/dark mode functionality while incorporating the latest changes from main branch. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
• Add ThemeProvider with system preference detection and localStorage persistence
• Create ThemeSwitcher component with sun/moon/desktop icons for auto/light/dark modes
• Update header styling to support dynamic theme switching
• Configure Tailwind CSS for class-based dark mode support
• Refactor existing theme configurations to use centralized themeConfig
• Update global styles for proper theme transitions across the application
Test plan
🤖 Generated with Claude Code