feat: Add admin functionality to set nodes as unclaimed #220

snomiao · 2025-10-11T07:17:17Z

use API to change publisher_id doesnt work yet, fix it in comfy-api

UPSTREAM IS MERGED: https://github.com/Comfy-Org/comfy-api/pull/678
PENDING NEXT DEPLOY

Summary

Adds admin functionality to set nodes as unclaimed in the registry-web admin panel. This allows administrators to remove the publisher association from a node, enabling scenarios where node authors need to transfer ownership or reclaim nodes under different publishers.

Changes

Admin Node Management Page (pages/admin/nodes.tsx):
- Added "Unclaim" button with warning color in the actions column
- Implemented confirmation modal showing node and publisher details
- Added handleUnclaim function using useAdminUpdateNode API
- Button only displays for nodes that have a publisher

Implementation Details

Uses the existing adminUpdateNode API endpoint which allows admins to update nodes without requiring publisher-specific permissions
Sets the publisher.id field to UNCLAIMED_ADMIN_PUBLISHER_ID to unclaim the node
Includes confirmation modal with warning about the action being irreversible
Displays loading state while the mutation is pending
Shows success/error toasts and invalidates queries to refresh the list

Test Plan

Build passes (bun run build)
ESLint passes with no new errors
Manual testing: Navigate to /admin/nodes as an admin
Manual testing: Click "Unclaim" button on a claimed node
Manual testing: Verify confirmation modal displays correct information
Manual testing: Confirm node becomes unclaimed after clicking "Unclaim Node"
Manual testing: Verify node can be re-claimed by the original author

Pull Request Overview

This PR adds admin functionality to unclaim nodes in the registry-web admin panel, allowing administrators to remove publisher associations from nodes. This enables scenarios where node ownership needs to be transferred or reclaimed under different publishers.

Key Changes:

Added "Unclaim" button to admin nodes page with confirmation workflow
Implemented unclaim functionality using UNCLAIMED_ADMIN_PUBLISHER_ID constant
Added internationalized strings for unclaim feature across 9 languages

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
pages/admin/nodes.tsx	Added unclaim button, confirmation modal, and handler using adminUpdateNode API
locales/en/common.json	Added English strings for unclaim feature
locales/zh/common.json	Added Chinese translations for unclaim feature
locales/tr/common.json	Added Turkish translations for unclaim feature
locales/ru/common.json	Added Russian translations for unclaim feature
locales/ko/common.json	Added Korean translations for unclaim feature
locales/ja/common.json	Added Japanese translations for unclaim feature
locales/fr/common.json	Added French translations for unclaim feature
locales/es/common.json	Added Spanish translations for unclaim feature
locales/ar/common.json	Added Arabic translations for unclaim feature

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

pages/admin/nodes.tsx

locales/es/common.json

locales/fr/common.json

locales/es/common.json

snomiao · 2025-10-25T12:15:50Z

also update this page /admin/claim-nodes to allow admins claim a node for specified publisher

This change adds a new "Unclaim" button to the admin node management page that allows administrators to remove the publisher association from a node. This enables scenarios where node authors need to transfer ownership or reclaim nodes under different publishers. Key changes: - Added useAdminUpdateNode hook to leverage admin privileges - Added "Unclaim" button with warning color in the actions column - Implemented confirmation modal with node and publisher details - Added handleUnclaim function that sets publisher to undefined - Only shows button for nodes that have a publisher 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

Co-authored-by: Copilot <[email protected]>

Added comprehensive email/password authentication functionality to the /auth/login page alongside existing social login options. Changes: - Enhanced AuthUI component with email/password form toggle - Implemented Firebase email/password authentication with error handling - Added form validation and user feedback - Integrated with existing authentication flow and redirect logic - Added i18n support for all new UI text and error messages - Responsive design that works with existing UI theme The login page now offers users choice between: - Google OAuth (existing) - GitHub OAuth (existing) - Email/Password (new) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

snomiao

Thanks for the review! Addressing the comments:

publisher field: The use of UNCLAIMED_ADMIN_PUBLISHER_ID is intentional and correct. The backend has a specific admin publisher ID (admin-11338bd3-f081-43cf-b3f9-295c829826f7) for unclaimed nodes, as defined in the backend code (https://github.com/Comfy-Org/comfy-api/blob/main/db/publisher.go#L13). Setting publisher to undefined would not work with the backend API contract.
Spanish translation for 'Current Publisher': Fixed in commit 8a402c9 - now translates to 'Editor Actual'
French translation for 'Unable to verify repository permissions': Fixed in commit 26f4f93 - now correctly translates to 'Impossible de vérifier les autorisations du dépôt. Veuillez réessayer.'
Spanish translation for 'Unable to verify repository permissions': Fixed in commit ccbdbd5 - now correctly translates to 'No se pueden verificar los permisos del repositorio. Por favor, inténtelo de nuevo.'

All translation issues have been resolved!

🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

- Resolved conflicts in AuthUI.tsx keeping email/password login functionality - Resolved conflicts in CreatePublisherModal.tsx using extracted CreatePublisherFormContent component - Resolved conflicts in pages/admin/nodes.tsx keeping unclaim node functionality - Resolved conflicts in pages/publishers/create.tsx using extracted component - Resolved conflicts in utils/comfyTheme.tsx using consistent dark theme colors - Resolved conflicts in all locale JSON files merging translation keys from both branches - Updated biome.json configuration from main branch - Applied code formatting with bun fmt 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 9 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-04T19:39:47Z

locales/zh/common.json

  "Author": "作者",
  "Back to Node Details": "返回节点详情",
  "Back to node details": "返回到节点详情",


Duplicate translation keys detected. Lines 29-31 are duplicated on lines 33-35, which will cause the later entries to override the earlier ones in the JSON object.

Suggested change

"Author": "作者",

"Back to Node Details": "返回节点详情",

"Back to node details": "返回到节点详情",

Copilot · 2025-11-04T19:39:47Z

locales/zh/common.json

+  "Unable to verify repository permissions. Please try again.": "无法验证仓库权限。请再试一次。",
+  "Unclaim Node": "取消认领节点",
+  "Unclaim node": "取消认领节点",
  "Unable to verify repository permissions. Please try again.": "无法验证仓库权限。请再试一次。",


Duplicate translation key 'Unable to verify repository permissions. Please try again.' appears twice, which will cause the second entry to override the first.

Suggested change

"Unable to verify repository permissions. Please try again.": "无法验证仓库权限。请再试一次。",

Copilot · 2025-11-04T19:39:48Z

locales/tr/common.json

  "Author": "Yazar",
  "Back to Node Details": "Düğüm Detaylarına Geri Dön",
  "Back to node details": "Düğüm detaylarına geri dön",


Duplicate translation keys detected. Lines 29-31 are duplicated on lines 33-35, which will cause the later entries to override the earlier ones in the JSON object.

Suggested change

"Author": "Yazar",

"Back to Node Details": "Düğüm Detaylarına Geri Dön",

"Back to node details": "Düğüm detaylarına geri dön",

Copilot · 2025-11-04T19:39:48Z

locales/tr/common.json

+  "Unable to verify repository permissions. Please try again.": "Depo izinleri doğrulanamadı. Lütfen tekrar deneyin.",
+  "Unclaim Node": "Sahiplenmeyi Kaldır Düğümünü",
+  "Unclaim node": "Sahiplenmeyi kaldır",
  "Unable to verify repository permissions. Please try again.": "Depo izinleri doğrulanamadı. Lütfen tekrar deneyin.",


Duplicate translation key 'Unable to verify repository permissions. Please try again.' appears twice, which will cause the second entry to override the first.

Suggested change

"Unable to verify repository permissions. Please try again.": "Depo izinleri doğrulanamadı. Lütfen tekrar deneyin.",

Copilot · 2025-11-04T19:39:48Z

locales/ru/common.json

  "Author": "Автор",
  "Back to Node Details": "Вернуться к деталям узла",
  "Back to node details": "Вернуться к деталям узла",


Duplicate translation keys detected. Lines 29-31 are duplicated on lines 33-35, which will cause the later entries to override the earlier ones in the JSON object.

Suggested change

"Author": "Автор",

"Back to Node Details": "Вернуться к деталям узла",

"Back to node details": "Вернуться к деталям узла",

Copilot · 2025-11-04T19:39:48Z

locales/ru/common.json

+  "Unable to verify repository permissions. Please try again.": "Невозможно проверить разрешения на репозиторий. Пожалуйста, попробуйте снова.",
+  "Unclaim Node": "Отменить заявку на узел",
+  "Unclaim node": "Отменить заявку на узел",
  "Unable to verify repository permissions. Please try again.": "Невозможно проверить разрешения на репозиторий. Пожалуйста, попробуйте снова.",


Duplicate translation key 'Unable to verify repository permissions. Please try again.' appears twice, which will cause the second entry to override the first.

Suggested change

"Unable to verify repository permissions. Please try again.": "Невозможно проверить разрешения на репозиторий. Пожалуйста, попробуйте снова.",

Copilot · 2025-11-04T19:39:49Z

locales/ja/common.json

  "Author": "作者",
  "Back to Node Details": "ノード詳細に戻る",
  "Back to node details": "ノードの詳細に戻る",


Duplicate translation keys detected. Lines 29-31 are duplicated on lines 33-35, which will cause the later entries to override the earlier ones in the JSON object.

Suggested change

"Author": "作者",

"Back to Node Details": "ノード詳細に戻る",

"Back to node details": "ノードの詳細に戻る",

Copilot · 2025-11-04T19:39:49Z

locales/ja/common.json

+  "Unable to verify repository permissions. Please try again.": "リポジトリ権限を確認できません。もう一度お試しください。",
+  "Unclaim Node": "ノードの請求を取り消す",
+  "Unclaim node": "ノードの請求を取り消す",
  "Unable to verify repository permissions. Please try again.": "リポジトリ権限を確認できません。もう一度お試しください。",


Duplicate translation key 'Unable to verify repository permissions. Please try again.' appears twice, which will cause the second entry to override the first.

Suggested change

"Unable to verify repository permissions. Please try again.": "リポジトリ権限を確認できません。もう一度お試しください。",

Copilot · 2025-11-04T19:39:49Z

locales/es/common.json

  "This node is already claimed and cannot be claimed again.": "Este nodo ya ha sido reclamado y no se puede reclamar nuevamente.",
  "This node is already claimed by a publisher.": "Este nodo ya ha sido reclamado por un editor.",
  "This node is already owned by a publisher and cannot be claimed.": "Este nodo ya ha sido reclamado por un editor y no puede ser reclamado nuevamente.",
  "This should only take a moment.": "这应该只需要一会儿。",


Spanish translation file contains Chinese text. This should be translated to Spanish: 'Esto solo debería tomar un momento.'

Suggested change

"This should only take a moment.": "这应该只需要一会儿。",

"This should only take a moment.": "Esto solo debería tomar un momento.",

vercel bot deployed to Preview October 11, 2025 07:18 View deployment

vercel bot deployed to Preview October 11, 2025 07:21 View deployment

vercel bot had a problem deploying to Preview October 11, 2025 07:30 Failure

vercel bot deployed to Preview October 11, 2025 07:39 View deployment

vercel bot deployed to Preview October 19, 2025 03:44 View deployment

snomiao marked this pull request as ready for review October 20, 2025 17:10

Copilot AI review requested due to automatic review settings October 20, 2025 17:10

snomiao self-assigned this Oct 20, 2025

Copilot AI reviewed Oct 20, 2025

View reviewed changes

pages/admin/nodes.tsx Outdated Show resolved Hide resolved

locales/es/common.json Outdated Show resolved Hide resolved

locales/fr/common.json Outdated Show resolved Hide resolved

locales/es/common.json Outdated Show resolved Hide resolved

vercel bot deployed to Preview October 24, 2025 00:31 View deployment

vercel bot deployed to Preview October 24, 2025 00:34 View deployment

vercel bot deployed to Preview October 24, 2025 00:35 View deployment

snomiao and others added 8 commits October 25, 2025 12:18

format: Apply prettier --fix changes

23f9b66

format: Apply prettier --fix changes

22247a5

Update locales/es/common.json

8a402c9

Co-authored-by: Copilot <[email protected]>

Update locales/fr/common.json

26f4f93

Co-authored-by: Copilot <[email protected]>

Update locales/es/common.json

ccbdbd5

Co-authored-by: Copilot <[email protected]>

format: Apply prettier --fix changes

c7f622a

snomiao commented Oct 25, 2025

View reviewed changes

snomiao force-pushed the sno-admin-unclaimed-set branch from 2b75f80 to 1e16eec Compare October 25, 2025 12:48

vercel bot deployed to Preview October 25, 2025 12:49 View deployment

format: Apply prettier --fix changes

8bc04d5

vercel bot deployed to Preview October 25, 2025 12:53 View deployment

snomiao and others added 2 commits October 26, 2025 07:54

format: Apply biome formatting from main branch

1f5592f

🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

vercel bot deployed to Preview October 26, 2025 08:35 View deployment

Merge branch 'main' into sno-admin-unclaimed-set

6dc703e

vercel bot deployed to Preview October 26, 2025 09:16 View deployment

Merge branch 'main' into sno-admin-unclaimed-set

82bf958

Copilot AI review requested due to automatic review settings November 4, 2025 19:36

snomiao enabled auto-merge (squash) November 4, 2025 19:36

vercel bot deployed to Preview November 4, 2025 19:38 View deployment

snomiao merged commit 84a59ab into main Nov 4, 2025
12 checks passed

snomiao deleted the sno-admin-unclaimed-set branch November 4, 2025 19:38

Copilot AI reviewed Nov 4, 2025

View reviewed changes

	"Author": "作者",
	"Back to Node Details": "返回节点详情",
	"Back to node details": "返回到节点详情",

	"Author": "Yazar",
	"Back to Node Details": "Düğüm Detaylarına Geri Dön",
	"Back to node details": "Düğüm detaylarına geri dön",

	"Author": "Автор",
	"Back to Node Details": "Вернуться к деталям узла",
	"Back to node details": "Вернуться к деталям узла",

	"Author": "作者",
	"Back to Node Details": "ノード詳細に戻る",
	"Back to node details": "ノードの詳細に戻る",

	"This should only take a moment.": "这应该只需要一会儿。",
	"This should only take a moment.": "Esto solo debería tomar un momento.",

feat: Add admin functionality to set nodes as unclaimed #220

feat: Add admin functionality to set nodes as unclaimed #220

Uh oh!

Conversation

snomiao commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Implementation Details

Test Plan

Related

Uh oh!

vercel bot commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

snomiao commented Oct 25, 2025

Uh oh!

snomiao left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

snomiao commented Oct 11, 2025 •

edited

Loading

vercel bot commented Oct 11, 2025 •

edited

Loading