Fix flux depth lora template uses flux-depth base model#25
Merged
christian-byrne merged 1 commit intomainfrom Apr 8, 2025
Merged
Fix flux depth lora template uses flux-depth base model#25christian-byrne merged 1 commit intomainfrom
christian-byrne merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Comfy-Org/ComfyUI#7407.
When using the lora format of the flux depth model, the base model should just be flux dev, rather than flux depth. This error occurs in the templates but not in the example workflows page.
Related fix to prevent this error from occurring accidentally in future: comfyanonymous/ComfyUI_examples#53
Also moves models metadata to node properties so it persists upon serialization.