PBS: Reload the config file when it changes #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltitanb
reviewed
Dec 7, 2025
| // Set up the filesystem watcher for the config file | ||
| let mut watcher: RecommendedWatcher; | ||
| if config_path.to_str() != Some("") { | ||
| let state_for_watcher = state.clone(); |
Collaborator
There was a problem hiding this comment.
would add a couple of logs:
- that we start the file watcher
- when trying to reload the config
crates/pbs/src/service.rs
Outdated
| let config_path_for_watcher = config_path.clone(); | ||
| watcher = RecommendedWatcher::new( | ||
| move |result: Result<Event, Error>| { | ||
| let event = result.unwrap(); |
Collaborator
Author
There was a problem hiding this comment.
That's just how their example usage worked, but I replaced it with a match in 8d77531.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes the first request in #382 by automatically reloading the config for the PBS service as though
/reloadwere called whenever the config file changes. There are a few ways to do this, but I settled on propagating the path from the config loader instead of making it a field within thePbsConfig, because it didn't feel like a good fit for that.Note that the Signer service doesn't do hot-reloading, because it's a much different setup that will require more planning. That might be OBE during the config revamp anyway so I'm leaving it out for now.