feat: Add logging for branchers #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maartenflippo
previously requested changes
Feb 3, 2025
github-actions
bot
dismissed
maartenflippo’s stale review
Review re-requested
maartenflippo
previously requested changes
Feb 27, 2025
| pub enum IteratedSolution<'a> { | ||
| /// A new solution was identified. | ||
| Solution(Solution, &'a Solver), | ||
| Solution(Solution, &'a Solver, &'a dyn Brancher), |
There was a problem hiding this comment.
Why use dyn here? In all the other solve results we are generic over Brancher.
pumpkin-solver/src/api/solver.rs
Outdated
| pub fn optimise<Var: IntegerVariable, Callback: Fn(&Solver, SolutionReference)>( | ||
| pub fn optimise< | ||
| Var: IntegerVariable, | ||
| Callback: Fn(&Solver, SolutionReference, &dyn Brancher), |
There was a problem hiding this comment.
Why dyn here? If we explicitly make a generic for impl Brancher then we can re-use that type in the signature here.
| @@ -14,15 +14,24 @@ use crate::Solver; | |||
| pub mod linear_sat_unsat; | |||
| pub mod linear_unsat_sat; | |||
|
|
|||
| pub trait OptimisationProcedure<Var: IntegerVariable, Callback: Fn(&Solver, SolutionReference)> { | |||
| pub trait OptimisationProcedure< | |||
There was a problem hiding this comment.
Why are the generics here? They do not seem to be used in any of the function signatures.
github-actions
bot
dismissed
maartenflippo’s stale review
Review re-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we only log statistics for propagators; however, it also makes sense to do this for branchers.
This PR proposes to add an additional method to the interface which logs statistics for branchers. A use-case is shown for our implementation of autonomous search.