feat: add method for retrieving relevant brancher events #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… events when add_brancher method is used
…nomous search when getting the relevant events
maartenflippo
previously requested changes
Feb 3, 2025
pumpkin-solver/src/branching/variable_selection/variable_selector.rs
Outdated
Show resolved
Hide resolved
github-actions
bot
dismissed
maartenflippo’s stale review
Review re-requested
maartenflippo
previously requested changes
Feb 10, 2025
maartenflippo
approved these changes
Feb 10, 2025
github-actions
bot
dismissed
maartenflippo’s stale review
Review re-requested
maartenflippo
force-pushed
the
feat/relevant-brancher-events
branch
from
4ff07c2 to
7f7d805
Compare
ImkoMarijnissen
force-pushed
the
feat/relevant-brancher-events
branch
from
7f7d805 to
4ff07c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some instances (e.g.
2023/code-generator/unison.mzn, with2023/code-generator/mips_gcc.flow.find_regno_partial.dzn), it showed up in profiling that the dynamic brancher went through a lot of branchers upon certain events (in this case theon_unassign_integerevent, even though only a single brancher was interested in these events).To alleviate this issue, this PR adds a method for
Branchers,VariableSelectors, andValueSelectors which allows them to indicate which events they are interested in; this allows theDynamicBrancherto only call theBranchers which are interested in it.