Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen view #440

Merged
merged 7 commits into from
Mar 13, 2024
Merged

Fullscreen view #440

merged 7 commits into from
Mar 13, 2024

Conversation

orhoj
Copy link
Contributor

@orhoj orhoj commented Mar 7, 2024

Purpose

Add a button that opens the browser wallet in fullscreen mode (in a tab).

Changes

  • Added button in settings that will open the wallet in a tab instead of the extension popup window.
  • Adjusted the UI of the wallet to work better in the fullscreen mode (centered, some margins, hide some overflows of menus, hide the connected box, go to identities page on issuance end, fix issue with web3id import popup window).

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@orhoj orhoj requested a review from shjortConcordium March 7, 2024 14:25
Copy link
Contributor

@shjortConcordium shjortConcordium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be nice to change to the tab, or make a notification/twinkle, when we return from identityIssuance/get requests from dapps. (But that is probably gold plating here)

@orhoj orhoj merged commit 1ef1818 into main Mar 13, 2024
4 checks passed
@orhoj orhoj deleted the fullscreen-view branch March 13, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants