Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust voting dapp to work with new voting smart contract interface #485

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

Victor-N-Suadicani
Copy link

Purpose

The voting smart contract was simplified and the interface changed slightly, so this needed adjustment as well.

Changes

Made the dapp conform to the new interface, primarily changing from using indices to using the options as strings.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@Victor-N-Suadicani Victor-N-Suadicani requested a review from DOBEN July 30, 2024 12:21
Copy link
Member

@DOBEN DOBEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Victor-N-Suadicani Victor-N-Suadicani merged commit ebaec2e into main Jul 30, 2024
7 checks passed
@Victor-N-Suadicani Victor-N-Suadicani deleted the fix_voting_dapp branch July 30, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants