Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new wallet-proxy endpoint and prepare release of 1.6.3 #491

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

limemloh
Copy link
Contributor

@limemloh limemloh commented Aug 19, 2024

Purpose

  • Use new wallet proxy endpoint with company ID providers
  • Prepare release of 1.6.3

Copy link
Collaborator

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I find it a little weird that the wallet proxy endpoint is a new version of an existing endpoint instead of a new v0 endpoint.. It puts us in a spot where it's hard to introduce breaking changes to the format returned while excluding company ID providers. Is this not a relevant consideration?

packages/browser-wallet/CHANGELOG.md Outdated Show resolved Hide resolved
@limemloh
Copy link
Contributor Author

LGTM, although I find it a little weird that the wallet proxy endpoint is a new version of an existing endpoint instead of a new v0 endpoint.. It puts us in a spot where it's hard to introduce breaking changes to the format returned while excluding company ID providers. Is this not a relevant consideration?

This was discussed offline, but to summarize: We still have the old endpoint available for other wallets and older versions of the browser wallets, currently we can't really do any breaking changes for this endpoint anyway.

@limemloh limemloh merged commit e49ae1e into main Aug 19, 2024
7 checks passed
@limemloh limemloh deleted the use-ip-info-v2 branch August 19, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants