Support for P10 #265
Draft
Support for P10 #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soerenbf
approved these changes
Nov 18, 2025
Comment on lines
+1088
to
+1090
| if update_keys.level_2_keys.create_plt.is_none() { | ||
| bail!("P10 requires createPLT authorization."); | ||
| } |
Contributor
There was a problem hiding this comment.
I guess this needs to be here for every protocol version >= 9. Would it make sense to figure out a way to do this once instead prior to this huge match statement, or are we fine with having to duplicate this for all eternity? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
_Describe the purpose of the pull request, link to issue describing the problem, etc.
Changes
Checklist
hard-to-understand areas.