Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hello world tutorial #1255

Merged
merged 7 commits into from
Apr 7, 2025
Merged

Add hello world tutorial #1255

merged 7 commits into from
Apr 7, 2025

Conversation

dragosgd
Copy link
Contributor

Purpose

Add hello world tutorial

Changes

-new hello world tutorial added

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

CLA acceptance

By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

@dragosgd dragosgd requested a review from it09 January 24, 2025 14:16
@dragosgd dragosgd self-assigned this Jan 24, 2025
Copy link
Contributor

@it09 it09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! left a couple of comments, mainly we need to add more explanations of what /why we do what we do :)

Dragos-Gabriel Danciulescu added 2 commits January 30, 2025 18:25
@dragosgd dragosgd requested a review from it09 January 30, 2025 16:32
@dragosgd
Copy link
Contributor Author

Good start! left a couple of comments, mainly we need to add more explanations of what /why we do what we do :)

You're right, I explained the entire process in more details and mentioned why methods were modified.

Copy link
Contributor

@it09 it09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay 🎉 Almost there!

@dragosgd dragosgd requested a review from it09 March 5, 2025 16:45
@it09 it09 merged commit af9021c into main Apr 7, 2025
2 checks passed
@it09 it09 deleted the helloWorldTutorial branch April 7, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants