Skip to content

fix: mobile responsive updates #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 13, 2025
Merged

fix: mobile responsive updates #1312

merged 6 commits into from
Mar 13, 2025

Conversation

harshitha-nano
Copy link
Collaborator

@harshitha-nano harshitha-nano commented Mar 10, 2025

Purpose

This PR improves the mobile responsiveness of the project by implementing the following updates:

Changes

  • Refactored layout for better mobile alignment
  • Enhanced readability and spacing
  • Improved typography for mobile screens
  • Updated media queries for adaptive behavior

Please let me know if you need any modifications! 🚀

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

CLA acceptance

_Remove if not applicable.

By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

@it09 it09 requested review from limemloh, dragosgd and Ivan-Mahda and removed request for limemloh and dragosgd March 11, 2025 14:51
@dragosgd dragosgd added the preview Trigger a documentation preview for a PR. label Mar 11, 2025
Copy link

github-actions bot commented Mar 11, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-03-13 11:38 UTC

@dragosgd dragosgd self-requested a review March 11, 2025 16:28
Copy link
Contributor

@dragosgd dragosgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the changes introduced horizontal scrolling in the desktop version of the homepage, so it won't fit the screen properly, see screenshot bellow.
Please fix this and check that the desktop version is not affected in any other way.
Otherwise, the problems I previously observed in the mobile version are fixed.
css-review-desktop-issue

@harshitha-nano
Copy link
Collaborator Author

Hi @dragosgd Thank you for the review and update. Sure I'll check the issue and resolve it please.

@harshitha-nano
Copy link
Collaborator Author

Hi @dragosgd

  • Fixed the horizontal scrolling issue on the desktop version of the homepage, ensuring it fits properly within the screen
  • Verified that no other unintended changes were introduced to the desktop layout

Please let me know if you need any modifications!

@harshitha-nano harshitha-nano requested a review from dragosgd March 11, 2025 18:36
Copy link
Contributor

@dragosgd dragosgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, previous problems were fixed, but I noticed a new problem with the side menus, indentation levels are missing. Before and after screenshots are attached bellow.
Here are the side menus before:
side_menu_left_before
side_menu_right_before
Here are the side menus after:
side_menu_left_after
side_menu_right_after

@harshitha-nano
Copy link
Collaborator Author

Hi @dragosgd Thank you, I'll check the sidebar menu and confirm you the updates.

@harshitha-nano
Copy link
Collaborator Author

Hi @dragosgd Please find the following screenshot for the indent correction

image
  • Identified and analysed the missing indentation levels in the side menus.
  • Reviewed before and after screenshots to understand the issue.
  • Fixed the indentation issue to restore proper menu hierarchy.
  • Ensured the fix does not introduce new issues on desktop or mobile.
  • Verified that previous fixes remain intact.

@harshitha-nano harshitha-nano requested a review from dragosgd March 12, 2025 11:18
@dragosgd dragosgd added preview Trigger a documentation preview for a PR. and removed preview Trigger a documentation preview for a PR. labels Mar 12, 2025
@dragosgd dragosgd merged commit a23abe5 into main Mar 13, 2025
2 checks passed
@dragosgd dragosgd deleted the fix/css-responsive-fixes branch March 13, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Trigger a documentation preview for a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants