Skip to content

Add exchange onboarding guide, update company ID guide #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 19, 2025

Conversation

dragosgd
Copy link
Contributor

Purpose

This PR creates a new Exchange Onboarding Guide that replaces the pdf version. The new guide follows the documentation outline specified in the related ticket. It also updates the Company identity creation guide.

Changes

  • Removed obsolete references to request.json and company_cli
  • Updated all documentation links to point to the current documentation
  • Reorganized the FAQ section
  • Added explicit mention that memo transfers can be implemented through SDKs or gRPC
  • Updated the gRPC section to reference gRPC V2 interface
  • Updated the related Company identity creation guide
    • Added GlobalFinReg as an alternative company identity provider that can be accessed directly through Wallet for Web and CryptoX

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

CLA acceptance

By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

@dragosgd dragosgd requested a review from bogacyigitbasi March 18, 2025 18:16
@dragosgd dragosgd self-assigned this Mar 18, 2025
@dragosgd dragosgd added the preview Trigger a documentation preview for a PR. label Mar 18, 2025
Copy link

github-actions bot commented Mar 18, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-03-19 14:21 UTC

@vadaynujra
Copy link

Hey @dragosgd, some feedback on the 'Company Identity Creation' guide:

  1. Why do we use Company identity in the guide while the wallet calls it Business ID? Might make sense to keep consistent.
  2. Company identities are therefore issued with documents that identify the company and not an individual. - I believe it is both - Company ID docs but also the individual docs of the UBOs (mentioned in the detailed steps under GFR. Maybe worth rewording to reflect that?
  3. Global FinReg - Can be accessed directly through Concordium Wallet for Web or CryptoX Concordium Wallet. Needs to mention that it's only on the Android version of CryptoX.
  4. Since Notabene cannot currently be used for Business ID creation, we should remove Notabene completely from this guide. The GFR section can also be generalised.
  5. Could we use screenshots from Mainnet as that is what the user will be expected to do and some differences in views might confuse them?

@dragosgd dragosgd added preview Trigger a documentation preview for a PR. and removed preview Trigger a documentation preview for a PR. labels Mar 19, 2025
@dragosgd
Copy link
Contributor Author

Hey @dragosgd, some feedback on the 'Company Identity Creation' guide:

  1. Why do we use Company identity in the guide while the wallet calls it Business ID? Might make sense to keep consistent.
  2. Company identities are therefore issued with documents that identify the company and not an individual. - I believe it is both - Company ID docs but also the individual docs of the UBOs (mentioned in the detailed steps under GFR. Maybe worth rewording to reflect that?
  3. Global FinReg - Can be accessed directly through Concordium Wallet for Web or CryptoX Concordium Wallet. Needs to mention that it's only on the Android version of CryptoX.
  4. Since Notabene cannot currently be used for Business ID creation, we should remove Notabene completely from this guide. The GFR section can also be generalised.
  5. Could we use screenshots from Mainnet as that is what the user will be expected to do and some differences in views might confuse them?

Hello @vadaynujra, here are the answers:

  1. I agree with this point, I can change that if @bogacyigitbasi agrees as well; I had to modify the outdated contents of the article, so I didn't change what was still valid.
  2. I could reword it to "... documents that identify both the company and an individual", but the main point is that company IDs are for the company to be on the blockchain, regardless of what individual uploads their docs, so I'm not sure. That part was in the original article as well.
  3. This has been addressed, in latest commits.
  4. As well, addressed in the latest commit, all mentions of Notabene and the old process have been removed.
  5. I didn't think there would be any difference, but yes, I could replace the screenshots with ones from mainnet. @bogacyigitbasi , let me know if I should do so before we merge or after.

@dragosgd dragosgd added preview Trigger a documentation preview for a PR. and removed preview Trigger a documentation preview for a PR. labels Mar 19, 2025
@dragosgd dragosgd merged commit 923ffbb into main Mar 19, 2025
2 checks passed
@dragosgd dragosgd deleted the exchangeOnBoardingGuide branch March 19, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Trigger a documentation preview for a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants